After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789706 - Fix invalid unref in artwork pixbuf
Fix invalid unref in artwork pixbuf
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-31 13:14 UTC by gkrithi8
Modified: 2017-10-31 22:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: remove extra pixbuf unref (663 bytes, patch)
2017-10-31 13:14 UTC, gkrithi8 		committed Details | Review

Description gkrithi8 2017-10-31 13:14:03 UTC 
Created attachment 362626 [details] [review]
shell: remove extra pixbuf unref

The following message is displayed:

sys:1: Warning: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

when g_object_unref (loader) is executed, as pixbuf is already unref'd, though loader owns it.
Comment 1 Jonathan Matthew 2017-10-31 22:07:58 UTC 
Review of attachment 362626 [details] [review]:

pushed as commit 1b4d16f62.

Can you start putting the bug URL in the commit message please?
Comment 2 gkrithi8 2017-10-31 22:13:14 UTC 
(In reply to Jonathan Matthew from comment #1)
> Review of attachment 362626 [details] [review] [review]:
> 
> pushed as commit 1b4d16f62.
> 
> Can you start putting the bug URL in the commit message please?

Sure.