GNOME Bugzilla – Bug 789649
testsuite sync sanity.sh to devhelp2.gz fix - warnings restored adds to log lines count
Last modified: 2017-11-03 20:00:26 UTC
Created attachment 362543 [details] [review] add 18 to expected_lines log lines count - account for restored warnings sanity.sh expects only the command line as output in the logs (expected_lines=1). Add 18 to those numbers to account for restored devhelp2.gz warning. This fix make check sanity.sh " DOC 00:00:01.520218581: Building HTML DOC 00:00:02.563148504: Fixing cross-references Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run: gunzip /usr/share/gtk-doc/html/gespeaker/gespeaker.devhelp2.gz Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run: gunzip /usr/share/gtk-doc/html/ogmrip/ogmdvd/ogmdvd.devhelp2.gz Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run: gunzip /usr/share/gtk-doc/html/ogmrip/ogmdvd-gtk/ogmdvd-gtk.devhelp2.gz Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run: gunzip /usr/share/gtk-doc/html/ogmrip/ogmjob/ogmjob.devhelp2.gz Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run: gunzip /usr/share/gtk-doc/html/ogmrip/ogmrip/ogmrip.devhelp2.gz Please fix https://bugs.launchpad.net/ubuntu/+source/gtk-doc/+bug/1466210 . For now run: gunzip /usr/share/gtk-doc/html/ogmrip/ogmrip-gtk/ogmrip-gtk.devhelp2.gz "
I think it would be better to suppress those by filtering them from the output files when counting lines. WDYT?
Created attachment 362786 [details] [review] discard references to launchapd bug 1466210 grep basic regular expression. I do not escape the dots, that would be overkill.
Created attachment 362787 [details] [review] git version - 362786: discard references to launchapd bug 1466210 Best to send the patch for git than old style. Here it is
The following fix has been pushed: 4e5429c tests: Fix sanity.sh lines count when devhelp2.gz warning is restored
Created attachment 362936 [details] [review] tests: Fix sanity.sh lines count when devhelp2.gz warning is restored Do so by discarding references to this warning.
I adjusted the regexp to match both messages. Thanks for the patch!