GNOME Bugzilla – Bug 789645
CMake modules fixes
Last modified: 2018-05-05 11:23:31 UTC
Created attachment 362524 [details] [review] FindGLIB2: Do not use REQUIRED to find PkgConfig and glib-2.0 1/5 - FindGLIB2: Do not use REQUIRED to find PkgConfig and glib-2.0 2/5 - FindGStreamer: Do not search for plugin dir if gstreamer was not found 3/5 - Fix QUIET flag in FindGStreamer and FindGStreamerPluginsBase 4/5 - FindGStreamer: Fix cases where gst.h and gstconfig.h are not in the s… 5/5 - Use GSTREAMER_INCLUDE_DIRS instead of GSTREAMER_INCLUDE_DIR
Created attachment 362525 [details] [review] FindGStreamer: Do not search for plugin dir if gstreamer was not found
Created attachment 362526 [details] [review] Fix QUIET flag in FindGStreamer and FindGStreamerPluginsBase
Created attachment 362527 [details] [review] FindGStreamer: Fix cases where gst.h and gstconfig.h are not in the same folder
Created attachment 362528 [details] [review] Use GSTREAMER_INCLUDE_DIRS instead of GSTREAMER_INCLUDE_DIR
Ping?
Thanks for the patches Daniele. qt-gstreamer is unmaintained, but I'm happy to push these patches to git master anyway. I would appreciate some kind of rationale what they are trying to achieve or fix however. The commit messages are a bit sparse. For example: why should pkgconfig / glib-2.0 not be required (patch 1)?
Hello Tim-Philipp, The paths detected by pkg-config are used as hint for the following find_library and find_path calls. By making them optional the pkg-config optional, cmake tries to detect the libraries even if pkg-config is not available. All the patches are required in order to fix the FindGStreamer module on a few systems I've been using them (I tested the CMake modules only, not the whole qt-gstreamer library). For example, on one of the systems (I cannot remember which one, sorry) the gst.h and gstconfig.h files were in different folders (patch 4 and 5) Also the patch 3 fixes the QUIET argument for the find_package command that is supposed to not print any message. Let me know if you need any specific information about the patches.
Hi Daniele, Long time no speak :) Hope you are doing well. I have pushed all the patches except number 3 "Fix QUIET flag...". It apparently makes cmake fail on master. Maybe you have applied some other local changes as well? If you want to rework that, let me know and I will push it. ----- commit 49bef1a1f1b383b2ada61c1fa84a836195d79ea2 Author: Daniele E. Domenichelli <daniele.domenichelli@iit.it> Date: Fri Oct 13 00:52:36 2017 +0200 Use GSTREAMER_INCLUDE_DIRS instead of GSTREAMER_INCLUDE_DIR commit 08659a08a39ce6c91df475d366fb7be6500e7ed3 Author: Daniele E. Domenichelli <daniele.domenichelli@iit.it> Date: Thu Oct 12 12:23:14 2017 +0200 FindGStreamer: Fix cases where gst.h and gstconfig.h are not in the same folder commit 6d3282c28340c688e7749c99c29b8f8f7065a418 Author: Daniele E. Domenichelli <daniele.domenichelli@iit.it> Date: Tue Oct 10 09:24:16 2017 +0200 FindGStreamer: Do not search for plugin dir if gstreamer was not found commit 13a6c5337b5f4407159c3d6aaea194c188c162a5 Author: Daniele E. Domenichelli <daniele.domenichelli@iit.it> Date: Mon Oct 9 13:19:39 2017 +0200 FindGLIB2: Do not use REQUIRED to find PkgConfig and glib-2.0
Created attachment 371676 [details] [review] Fix QUIET flag in FindGStreamer and FindGStreamerPluginsBase
Sorry, Daniele, I'm still getting errors: CMake Error at cmake/modules/FindGStreamerPluginsBase.cmake:34 (find_gstreamer_library): find_gstreamer_library Macro invoked with incorrect arguments for macro named: find_gstreamer_library Call Stack (most recent call first): cmake/modules/FindGStreamerPluginsBase.cmake:41 (_find_gst_plugins_base_component) CMakeLists.txt:88 (find_package) CMake Error at cmake/modules/FindGStreamerPluginsBase.cmake:34 (find_gstreamer_library): find_gstreamer_library Macro invoked with incorrect arguments for macro named: find_gstreamer_library Call Stack (most recent call first): cmake/modules/FindGStreamerPluginsBase.cmake:43 (_find_gst_plugins_base_component) CMakeLists.txt:88 (find_package) CMake Error at cmake/modules/FindGStreamerPluginsBase.cmake:34 (find_gstreamer_library): find_gstreamer_library Macro invoked with incorrect arguments for macro named: find_gstreamer_library Call Stack (most recent call first): cmake/modules/FindGStreamerPluginsBase.cmake:59 (_find_gst_plugins_base_component) CMakeLists.txt:88 (find_package) CMake Error at cmake/modules/FindGStreamerPluginsBase.cmake:34 (find_gstreamer_library): find_gstreamer_library Macro invoked with incorrect arguments for macro named: find_gstreamer_library Call Stack (most recent call first): cmake/modules/FindGStreamerPluginsBase.cmake:57 (_find_gst_plugins_base_component) CMakeLists.txt:88 (find_package)
Created attachment 371678 [details] [review] Fix QUIET flag in FindGStreamer and FindGStreamerPluginsBase (v2)
Hello George, long time, indeed! Thanks! Hope you're doing well, too. Sorry, I re-uploaded the wrong version! The latest patch should be fixed. Thanks! Daniele
Pushed, thanks.