After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789632 - signal 'entry-deleted' is invalid for instance of type 'RhythmDBQueryModel'
signal 'entry-deleted' is invalid for instance of type 'RhythmDBQueryModel'
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-29 20:55 UTC by gkrithi8
Modified: 2017-10-30 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
widgets: connect to query-model::post-entry-delete signal for rb_song_info_update_buttons() to work properly (1.41 KB, patch)
2017-10-29 21:00 UTC, gkrithi8 		committed Details | Review

Description gkrithi8 2017-10-29 20:55:20 UTC 
Selecting 'Properties' for an entry in the entry view, and change the property in the property view ( with the song info widget open ) should display this error.
Comment 1 gkrithi8 2017-10-29 21:00:42 UTC 
Created attachment 362498 [details] [review]
widgets: connect to query-model::post-entry-delete signal for rb_song_info_update_buttons() to work properly

There is no "entry-deleted" signal for query-model. Either there is a "row-deleted" from GtkTreeModel (or) "entry-removed" from rhythmdb-query-model. Strictly speaking rhythmdb-query-model should emit "row-deleted" only after the row in the model is deleted. But, it is done prior to deletion, and a "post-entry-delete" signal is added for the post deletion case. So, we listen on that for rb_song_info_update_buttons() to work.
Comment 2 Jonathan Matthew 2017-10-30 22:15:33 UTC 
Review of attachment 362498 [details] [review]:

pushed as commit 5f547681c