After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789557 - ship app icon
ship app icon
Status: RESOLVED OBSOLETE
Product: gucharmap
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-27 13:03 UTC by Jakub Steiner
Modified: 2021-06-02 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icons: ship app icon with gucharmap (97.18 KB, patch)
2017-10-27 13:05 UTC, Jakub Steiner
none Details | Review
icons: ship app icon with gucharmap (97.28 KB, patch)
2017-11-03 12:12 UTC, Jakub Steiner
none Details | Review
icons: use the new app icon asset (1.32 KB, patch)
2017-11-03 13:24 UTC, Jakub Steiner
none Details | Review

Description Jakub Steiner 2017-10-27 13:03:00 UTC
Even core apps should ship their own app icon.
Comment 1 Jakub Steiner 2017-10-27 13:05:04 UTC
Created attachment 362413 [details] [review]
icons: ship app icon with gucharmap

- to move to the great new Flatpak future, Apps should rely on shiping
  their own app icons, their identity. For more context, see

  https://wiki.gnome.org/action/edit/Design/Whiteboards/CoreAppPresentation
Comment 2 Christian Persch 2017-10-27 18:18:47 UTC
Thanks.

The .svg contains this:

   inkscape:export-filename="/home/jimmac/Desktop/wi-fi.png"

which doesn't seem correct. Also it lacks a copyright header; to be able to ship with gucharmap, it will need to be GPL3+.

How are the pngs created from the .svg source? If it's a manual process, should detail it in the commit message; if you did it with a script, the script will need to be committed (and under GPL3+) too.

You need to update the desktop file and gucharmap-window.c to refer to this icon instead of accessories-character-map.
Comment 3 Jakub Steiner 2017-11-03 12:11:21 UTC
It's perfectly viable to manually export the PNGs, but I did use the script that's part of adwaita icon theme[1].

Inkscape only provides a handful of licenses to pick in the metadata properties, so the only viable option was 'other' and pointing to the gpl3.

As for how to get the asset used, I'll leave to that someone more competent.

[1] https://git.gnome.org/browse/adwaita-icon-theme/tree/render-icon-theme.py
Comment 4 Jakub Steiner 2017-11-03 12:12:43 UTC
Created attachment 362898 [details] [review]
icons: ship app icon with gucharmap

- to move to the great new Flatpak future, Apps should rely on shiping
  their own app icons, their identity. For more context, see

  https://wiki.gnome.org/action/edit/Design/Whiteboards/CoreAppPresentation
Comment 5 Jakub Steiner 2017-11-03 13:24:02 UTC
Created attachment 362900 [details] [review]
icons: use the new app icon asset

- use gucharmap instead of the accessories-character-map that will go away
  https://wiki.gnome.org/action/edit/Design/Whiteboards/CoreAppPresentation
Comment 6 Jakub Steiner 2017-11-03 13:24:39 UTC
Just a search and replace on the last patch. UNlikely to work, but wanted to be as helpful as I can be.
Comment 7 Christian Persch 2018-03-28 21:51:38 UTC
Sorry this fell off my list...

So I just need you to confirm you're licensing the icon source under GPL 3+, and I'll get this done for the next release.
Comment 8 GNOME Infrastructure Team 2021-06-02 09:36:07 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gucharmap/-/issues/478.