GNOME Bugzilla – Bug 789531
Don't depend on the system shell
Last modified: 2017-11-12 20:27:37 UTC
This the last thing currently patched in MSYS2 to make the new gtk-doc work on Windows (some packages still produce empty docs and I haven't looked into that). I'm not that familiar with the scangobj interface and if there are any other dependencies on the shell besides argument splitting, which I have replaced using "shlex.split()". https://github.com/Alexpux/MINGW-packages/blob/c56636ab4c0d78e32dae7d0d35389b0a71433269/mingw-w64-gtk-doc/win-fixes.patch If this is something that looks good for inclusion I can turn it into a proper patch.
Created attachment 362372 [details] [review] scanobj: Don't depend on the system shell * Instead of piping to /dev/null use check_output which pipes the output to a return value by default * Instead of passing the argument list through as is, split them with shlex.split() and pass them as a proper argument list. This makes it possible to run gtk-doc under Windows with mingw.
The following fix has been pushed: d334d55 scanobj: Don't depend on the system shell
Created attachment 362785 [details] [review] scanobj: Don't depend on the system shell * Instead of piping to /dev/null use check_output which pipes the output to a return value by default * Instead of passing the argument list through as is, split them with shlex.split() and pass them as a proper argument list. This makes it possible to run gtk-doc under Windows with mingw.
Thanks, committed with a small quoting change.
Thanks!
This caused some regression https://bugzilla.gnome.org/show_bug.cgi?id=789800 could you take a look too?
So, given the problem stated in https://bugzilla.gnome.org/show_bug.cgi?id=789800#c10 Should I look into fixing those cases by converting leading arguments containing "=" to env vars or leave it and let webkit not pass env vars in the command?
If we can easily print a warning, that might be nice. Since the fix is easy for the affected project, I would not complicate the code if possible.