After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789506 - avidemux: Handled buffer mapping failures
avidemux: Handled buffer mapping failures
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.12.3
Other All
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-26 06:22 UTC by Ashish Kumar
Modified: 2018-05-07 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] gst-plugins-good: gstavidemux: Handled buffer mapping failures (10.48 KB, patch)
2017-10-26 06:26 UTC, Ashish Kumar 		none Details | Review

Description Ashish Kumar 2017-10-26 06:22:35 UTC 
Buffer mapping failure must be handled at below code:-
File: gst-plugins-good-1.12.3/gst/avi/gstavidemux.c

Failure of function gst_buffer_map must be handled at all places.
Comment 1 Ashish Kumar 2017-10-26 06:26:35 UTC 
Created attachment 362308 [details] [review]
[PATCH] gst-plugins-good: gstavidemux: Handled buffer mapping failures

Please review the patch attached to fix the issue and share your feedback.
Comment 2 Tim-Philipp Müller 2017-10-26 08:43:45 UTC 
Do we really need to test buffer mapping for buffers allocated with the sysmem allocator? Esp. those we allocated ourselves?
Comment 3 Sebastian Dröge (slomo) 2017-10-26 08:54:45 UTC 
If we allocated them ourselves, no. Otherwise the mapping can in theory fail (ex: multiple memories getting merged together, but the allocation for the bigger memory area fails).
Comment 4 Sebastian Dröge (slomo) 2018-05-07 16:06:24 UTC 
See comment 2