After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789494 - brasero-disc-recorder: Fix invalid object reference warnings
brasero-disc-recorder: Fix invalid object reference warnings
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-25 20:56 UTC by gkrithi8
Modified: 2017-10-26 11:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
brasero-disc-recorder: Fix invalid object reference warnings (1010 bytes, patch)
2017-10-25 21:00 UTC, gkrithi8 		committed Details | Review

Description gkrithi8 2017-10-25 20:56:38 UTC 
With brasero-disc-recorder enabled, Rhythmbox emits the following warnings in console, when grilo source is selected followed by selecting another source.

sys:1: Warning: invalid (NULL) pointer instance
sys:1: Warning: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
sys:1: Warning: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
Comment 1 gkrithi8 2017-10-25 21:00:45 UTC 
Created attachment 362294 [details] [review]
brasero-disc-recorder: Fix invalid object reference warnings

We connect to signals only from query-models in "playlist source" type ( and its inherited types ), so do the same for signal disconnect.
Comment 2 Jonathan Matthew 2017-10-26 11:50:22 UTC 
Review of attachment 362294 [details] [review]:

pushed as commit fbb6ad7fb