GNOME Bugzilla – Bug 789457
adaptivedemux: add replaced flag to not error out on bitrate change
Last modified: 2017-10-27 10:35:50 UTC
With HLS it is common to have a live stream abort when it is trying to download ahead of the last fragment and it tries to switch bitrate at the same time. This fixes the problem by having an extra flag to signal the stream is being replaced due to a bitrate change rather than an error. So we can differentiate and avoid erroring out mistakenly
Created attachment 362236 [details] [review] adaptivedemux: add replaced flag to not error out on bitrate change When switching bitrates we set the old streams as cancelled, but it could also be confused with a cancel due to other reasons (as an error) and it would lead the element to stop the pipeline mistankely. This would happen when the stream being replaced was waiting for a manifest update on live. Ss make it sure that we are stopping for switching bitrates to avoid erroring out.
*** Bug 789084 has been marked as a duplicate of this bug. ***
commit c2d34d1e44fbe6c4a0e7792b8d22e1059a4b1db7 Author: Thiago Santos <thiagossantos@gmail.com> Date: Sat Oct 14 13:22:18 2017 -0700 adaptivedemux: add replaced flag to not error out on bitrate change When switching bitrates we set the old streams as cancelled, but it could also be confused with a cancel due to other reasons (as an error) and it would lead the element to stop the pipeline mistankely. This would happen when the stream being replaced was waiting for a manifest update on live. Ss make it sure that we are stopping for switching bitrates to avoid erroring out. https://bugzilla.gnome.org/show_bug.cgi?id=789457
I have applied this patch to my local 1.12.3 and it works with offsets. I have run it for a couple of hours without any "Could not download fragments" errors. I got these once in while quite 'reliably' before over wireless.