After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789442 - Add libxml2 DTD bindings
Add libxml2 DTD bindings
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-24 22:20 UTC by Daniel Espinosa
Modified: 2017-10-26 06:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adds missing DTD bindins to TextWriter (3.62 KB, patch)
2017-10-24 22:20 UTC, Daniel Espinosa 		none Details | Review
patch updated against current master (3.60 KB, patch)
2017-10-25 18:29 UTC, Daniel Espinosa 		none Details | Review
libxml-2.0: Add DTD methods (3.94 KB, patch)
2017-10-25 19:12 UTC, Rico Tzschichholz 		none Details | Review
libxml-2.0: Add DTD methods (4.19 KB, patch)
2017-10-26 06:16 UTC, Rico Tzschichholz 		committed Details | Review

Description Daniel Espinosa 2017-10-24 22:20:13 UTC 
Created attachment 362224 [details] [review]
Adds missing DTD bindins to TextWriter

There are missing bindings for xmlTextWritter for DTD.
Comment 1 Daniel Espinosa 2017-10-24 22:21:15 UTC 
Please, don't forget to backport to 0.34, 0.36 and 0.38. This patch is needed for GXml and GSVG to generated DOCTYPE definitions.
Comment 2 Rico Tzschichholz 2017-10-25 06:53:21 UTC 
Review of attachment 362224 [details] [review]:

Please make sure this applies to the current git master.

Also call it "libxml-2.0: Add DTD methods"
Comment 3 Daniel Espinosa 2017-10-25 18:29:39 UTC 
Created attachment 362285 [details] [review]
patch updated against current master

I've create a new patch against master.
Comment 4 Rico Tzschichholz 2017-10-25 19:12:07 UTC 
Created attachment 362288 [details] [review]
libxml-2.0: Add DTD methods
Comment 5 Rico Tzschichholz 2017-10-25 19:12:26 UTC 
Reordered and dropped duped "xmlTextWriterWriteDTD"
Comment 6 Rico Tzschichholz 2017-10-25 19:27:23 UTC 
@daniel: Btw relying on a proposed vala change while gxml is part of vala-ci and therefore breaking it, is not a nice move. :(
Comment 8 Daniel Espinosa 2017-10-25 21:36:17 UTC 
(In reply to Rico Tzschichholz from comment #6)
> @daniel: Btw relying on a proposed vala change while gxml is part of vala-ci
> and therefore breaking it, is not a nice move. :(

I'll take more care in the future. Sorry for the inconvenience.
Comment 9 Daniel Espinosa 2017-10-25 21:43:31 UTC 
Review of attachment 362288 [details] [review]:

I've mapped xmlTextWriterDTD to write_document_type(), because xmlTextWriterWriteDocType is a macro calling xmlTextWriterDTD, as decribed at:

http://xmlsoft.org/html/libxml-xmlwriter.html
Comment 10 Rico Tzschichholz 2017-10-26 05:21:38 UTC 
(In reply to Daniel Espinosa from comment #9)
> Review of attachment 362288 [details] [review] [review]:
> 
> I've mapped xmlTextWriterDTD to write_document_type(), because
> xmlTextWriterWriteDocType is a macro calling xmlTextWriterDTD, as decribed
> at:
> 
> http://xmlsoft.org/html/libxml-xmlwriter.html

OK, then you should have actually used xmlTextWriterWriteDocType to avoid the confusion.
Comment 11 Rico Tzschichholz 2017-10-26 06:16:24 UTC 
Created attachment 362307 [details] [review]
libxml-2.0: Add DTD methods
Comment 12 Rico Tzschichholz 2017-10-26 06:17:39 UTC 
Attachment 362307 [details] pushed as 8688d24 - libxml-2.0: Add DTD methods