After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789413 - isomp4: atoms_recovery: Handled buffer mapping
isomp4: atoms_recovery: Handled buffer mapping
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.12.3
Other All
: Normal minor
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-24 14:49 UTC by Ashish Kumar
Modified: 2017-10-26 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] gst-plugins-good: atoms_recovery: Handled buffer mapping failure (1011 bytes, patch)
2017-10-24 14:50 UTC, Ashish Kumar 		committed Details | Review

Description Ashish Kumar 2017-10-24 14:49:30 UTC 
Buffer mapping failure must be handled at below code:-
File: gst-plugins-good-1.12.3/gst/isomp4/atomsrecovery.c
Function: atoms_recov_write_ftyp_info
...
  if (prefix) {
    GstMapInfo map;

    gst_buffer_map (prefix, &map, GST_MAP_READ);
    if (fwrite (map.data, 1, map.size, f) != map.size) {
      gst_buffer_unmap (prefix, &map);
      return FALSE;
    }
    gst_buffer_unmap (prefix, &map);
  }
...

Failure of function gst_buffer_map must be handled.
Comment 1 Ashish Kumar 2017-10-24 14:50:36 UTC 
Created attachment 362190 [details] [review]
[PATCH] gst-plugins-good: atoms_recovery: Handled buffer mapping failure

Please review the patch attached to fix the issue and share your feedback.
Comment 2 Thiago Sousa Santos 2017-10-25 06:04:04 UTC 
commit 1aed3948a83a810f4b0da9666dee7ea867f05309
Author: Ashish Kumar <kr.ashish@samsung.com>
Date:   Tue Oct 24 20:12:29 2017 +0530

    gst-plugins-good: atoms_recovery: Handled buffer mapping failure
    
    https://bugzilla.gnome.org/show_bug.cgi?id=789413


Thanks for your patch. Please make sure to have gnu-indent installed on your system so that it verifies your code against the coding guidelines for the next patches.