GNOME Bugzilla – Bug 789403
avwait: Added end-timecode property
Last modified: 2017-10-25 11:56:53 UTC
See commit message
Created attachment 362180 [details] [review] avwait: Added end-timecode property avwait can now be configured to stop when a given timecode has been reached. It will start at the timecode indicated with start-timecode and end at the timecode indicated with end-timecode. If end-timecode is NULL (default), the previous functionality is preserved: keep going and not end.
Review of attachment 362180 [details] [review]: Looks good to me otherwise, please push once this is fixed :) ::: gst/timecode/gstavwait.c @@ -385,0 +417,22 @@ + if (self->end_tc + && gst_video_time_code_compare (self->tc, self->end_tc) != -1) { + gchar *start_tc, *end_tc; ... 19 more ... copy paste issue ? :)
Thanks for the review! :) (In reply to Mathieu Duponchelle from comment #2) > > ::: gst/timecode/gstavwait.c > @@ -385,0 +417,22 @@ > + if (self->end_tc > + && gst_video_time_code_compare (self->tc, self->end_tc) != -1) { > + gchar *start_tc, *end_tc; > ... 19 more ... > > copy paste issue ? :) Not really :) There is the same check but slightly different actions that have to be taken in three different places: 1) we provide start-timecode as string and it turns out to be after the end-timecode: don't bother stringifying the start timecode, reject it (I'd say, not bother creating it at the first place either - will update the patch) 2) we provide start-timecode as an object and it turns out to be after the end-timecode: stringify both, reject start-timecode 3) we provide end-timecode as an object and it turns out to be after the start-timecode: stringify both, reject end-timecode
(In reply to Vivia Nikolaidou from comment #3) > > 1) we provide start-timecode as string and it turns out to be after the > end-timecode: don't bother stringifying the start timecode, reject it (I'd > say, not bother creating it at the first place either - will update the > patch) > Oops, we actually do have to create it in order to compare it! :) So it's OK as it is.
Created attachment 362250 [details] [review] avwait: Added end-timecode property avwait can now be configured to stop when a given timecode has been reached. It will start at the timecode indicated with start-timecode and end at the timecode indicated with end-timecode. If end-timecode is NULL (default), the previous functionality is preserved: keep going and not end.
Attachment 362250 [details] pushed as a160b85 - avwait: Added end-timecode property