After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789377 - global: make possible to set debug-flags dynamically
global: make possible to set debug-flags dynamically
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-24 00:16 UTC by Marco Trevisan (Treviño)
Modified: 2018-01-25 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
global: make possible to set debug-flags dynamically (8.57 KB, patch)
2017-10-24 00:16 UTC, Marco Trevisan (Treviño)
none Details | Review
main: increase the granularity of backtraces in SHELL_DEBUG (5.35 KB, patch)
2017-10-24 01:22 UTC, Marco Trevisan (Treviño)
none Details | Review
global: make possible to set debug-flags dynamically (7.83 KB, patch)
2017-10-24 05:45 UTC, Marco Trevisan (Treviño)
none Details | Review
main: increase the granularity of backtraces in SHELL_DEBUG (5.68 KB, patch)
2017-10-24 05:46 UTC, Marco Trevisan (Treviño)
none Details | Review
main: increase the granularity of backtraces in SHELL_DEBUG (5.69 KB, patch)
2017-10-24 06:32 UTC, Marco Trevisan (Treviño)
none Details | Review

Description Marco Trevisan (Treviño) 2017-10-24 00:16:23 UTC
Adding {set,get}_debug_flags functions to the shell global object to
make possible to set this easily from looking class, making it easier
for developers and users to debug without having to restart the shell
with environment variables.

Debug flags in main are updated when the "debug-flags" property is
changed. I'm keeping this as a string-list so that it's easier to update.
Comment 1 Marco Trevisan (Treviño) 2017-10-24 00:16:27 UTC
Created attachment 362125 [details] [review]
global: make possible to set debug-flags dynamically

Adding {set,get}_debug_flags functions to the shell global object to
make possible to set this easily from looking class, making it easier
for developers and users to debug without having to restart the shell
with environment variables.

Debug flags in main are updated when the "debug-flags" property is
changed. I'm keeping this as a string-list so that it's easier to update.
Comment 2 Marco Trevisan (Treviño) 2017-10-24 01:22:53 UTC
Created attachment 362126 [details] [review]
main: increase the granularity of backtraces in SHELL_DEBUG

This is an optional extra, which allows to control the debug flags
with better granularity... Not indispensable, but nice to have IMHO.
Comment 3 Marco Trevisan (Treviño) 2017-10-24 01:25:00 UTC
Review of attachment 362125 [details] [review]:

.

::: src/shell-global.h
@@ +130,3 @@
                                                  const char   *property_name);
+const char * shell_global_get_debug_flags       (ShellGlobal  *global);
+void     shell_global_set_debug_flags           (ShellGlobal  *global,

This file is quite messy in alignment... This is aligned with other void functions, but let me know if you prefer in other way.
Comment 4 Marco Trevisan (Treviño) 2017-10-24 05:45:58 UTC
Created attachment 362135 [details] [review]
global: make possible to set debug-flags dynamically

Update the patch based on updates on Bug 789237
Comment 5 Marco Trevisan (Treviño) 2017-10-24 05:46:20 UTC
Created attachment 362136 [details] [review]
main: increase the granularity of backtraces in SHELL_DEBUG

Rebasing...
Comment 6 Marco Trevisan (Treviño) 2017-10-24 06:32:08 UTC
Created attachment 362143 [details] [review]
main: increase the granularity of backtraces in SHELL_DEBUG

Rebasing on master (and a fix).
Comment 7 Marco Trevisan (Treviño) 2018-01-25 17:00:20 UTC
Continuing here https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/6