After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789342 - Gnome Contacts crashes immediately under X when a contact with local address is opened
Gnome Contacts crashes immediately under X when a contact with local address ...
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.26
Other Linux
: Normal major
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-10-23 09:56 UTC by gunwald
Modified: 2018-01-24 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Change map provider (2.21 KB, patch)
2017-11-04 21:02 UTC, Günther Wutz
none Details | Review

Description gunwald 2017-10-23 09:56:19 UTC
When I click at a contact which has a local address Gnome Contacts crashes immediately after the little map was loaded. So I guess the crash has to do something with the integration of maps. Starting the application form the terminal it throws the following when going down:

gnome-contacts 

>  (gnome-contacts:27554): libchamplain-CRITICAL **: champlain_view_set_map_source: assertion 'CHAMPLAIN_IS_VIEW (view) && CHAMPLAIN_IS_MAP_SOURCE (source)' failed

  (gnome-contacts:27554): libchamplain-CRITICAL **: champlain_view_set_map_source: assertion 'CHAMPLAIN_IS_VIEW (view) && CHAMPLAIN_IS_MAP_SOURCE (source)' failed

  (gnome-contacts:27554): folks-WARNING **: Invalid e-mail address when looking for potential match: +49 XXXXXXXX

  (gnome-contacts:27554): Gdk-ERROR **: The program 'gnome-contacts' received an X Window System error.
  This probably reflects a bug in the program.
  The error was 'GLXBadDrawable'.
    (Details: serial 12326 error_code 171 request_code 155 (GLX) minor_code 29)
    (Note to programmers: normally, X errors are reported asynchronously;
     that is, you will receive the error a while after causing it.
     To debug your program, run it with the GDK_SYNCHRONIZE environment
     variable to change this behavior. You can then get a meaningful
     backtrace from your debugger if you break on the gdk_x_error() function.)
  Trace/Breakpoint ausgelöst

This error exists at least since Version 3.20. Due to this problem the application is unusable.
Comment 1 Günther Wutz 2017-11-04 21:02:45 UTC
Created attachment 362996 [details] [review]
Change map provider

I looked into this and have at least a fix for the first error.

Mapquest got shut down and is therefor deprecated. I changed the map provider for now to an available one (the api provides some more). Speaking about a long term solution we should do it exactly like Gnome maps and use their API to gather the available map provider from the internet (and be able to change it in case there is a problem with the current one)

Maybe it fixes the GLX problem for you but i am not sure.
Comment 2 Niels De Graef 2017-11-04 22:06:44 UTC
Hey Günther!

First of all, thanks for reporting and investigating this issue. I've already been in contact with the GNOME Maps devs to find out whether we could use their JSON file describing services. At the moment, I'm still waiting for a definitive answer on the course we can/should take in the long term.

Cheers
Comment 3 Niels De Graef 2017-12-29 16:54:16 UTC
Hey everyone!

Just a small update: I still haven't gotten a reply, so I've (temporarily) added a compilation option to not include the maps.
Comment 4 Niels De Graef 2018-01-19 18:11:45 UTC
Okay, I've been discussing this with several people, and this is the end result.

As of commit de836fe on master, we will no longer show a map when an address is shown. Since it introduced crashes on X (bug 789342), rendering problems on Wayland (bug 765274) and in general (bug 754609), *and* we're not even sure whether we can even use GNOME's tile provider, this should not be too much of a contested decision. In any case, I made bug 792694 to make sure that we still open GNOME Maps when an address is clicked, which I will make sure lands asap.

Cheers,
Niels