After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789338 - rtpmanager: improve performance in NACK/RTX handling
rtpmanager: improve performance in NACK/RTX handling
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.3
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-23 08:26 UTC by Miguel París Díaz
Modified: 2018-11-03 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtprtxqueue: add property to allow pushing all buffers pending to be rettransmited together (5.22 KB, patch)
2017-10-23 08:26 UTC, Miguel París Díaz 		none Details | Review
rtpsession: add attr to configure reporting all RTX seqnums together in GstRTPRetransmissionListRequest (10.39 KB, patch)
2017-10-23 08:26 UTC, Miguel París Díaz 		none Details | Review
rtprtxqueue: support GstRTPRetransmissionListRequest (2.26 KB, patch)
2017-10-23 08:26 UTC, Miguel París Díaz 		none Details | Review
rtprtxqueue: improve performance in RTX request handling (7.64 KB, patch)
2017-10-23 08:27 UTC, Miguel París Díaz 		none Details | Review
rtpsession: provide RTT in RetransmissionRequest events (7.16 KB, patch)
2017-10-23 08:27 UTC, Miguel París Díaz 		none Details | Review
rtprtxqueue: add "rtx_min_delay" (6.58 KB, patch)
2017-10-23 08:27 UTC, Miguel París Díaz 		none Details | Review
rtpsession: support for receiving GstRTPRetransmissionListRequest (4.26 KB, patch)
2017-10-23 08:28 UTC, Miguel París Díaz 		none Details | Review
rtprtxqueue: add stats about retransmissions (6.86 KB, patch)
2017-10-23 08:29 UTC, Miguel París Díaz 		none Details | Review

Description Miguel París Díaz 2017-10-23 08:26:03 UTC 
Hello,
I am providing several changes to improve NACK/RTX handling.
The general remarks are:
  - Add GstRTPRetransmissionListRequest that allows send a list of seqnum to ask for NACKS. avoiding sending a lot of events on packet looses bursts.
  - GstRtpRtxQueue: several changes to avoid unnecessary operations.
  - Add "rtt" field in both GstRTPRetransmissionRequest and GstRTPRetransmissionListRequest that allows upstream elements like GstRtpRtxQueue to send retransmissions under the RTT.

Anyway, each commit has more detailed info.
Comment 1 Miguel París Díaz 2017-10-23 08:26:20 UTC 
Created attachment 362075 [details] [review]
rtprtxqueue: add property to allow pushing all buffers pending to be rettransmited together
Comment 2 Miguel París Díaz 2017-10-23 08:26:40 UTC 
Created attachment 362076 [details] [review]
rtpsession: add attr to configure reporting all RTX seqnums together in GstRTPRetransmissionListRequest
Comment 3 Miguel París Díaz 2017-10-23 08:26:55 UTC 
Created attachment 362077 [details] [review]
rtprtxqueue: support GstRTPRetransmissionListRequest
Comment 4 Miguel París Díaz 2017-10-23 08:27:18 UTC 
Created attachment 362078 [details] [review]
rtprtxqueue: improve performance in RTX request handling
Comment 5 Miguel París Díaz 2017-10-23 08:27:36 UTC 
Created attachment 362079 [details] [review]
rtpsession: provide RTT in RetransmissionRequest events
Comment 6 Miguel París Díaz 2017-10-23 08:27:59 UTC 
Created attachment 362080 [details] [review]
rtprtxqueue: add "rtx_min_delay"
Comment 7 Miguel París Díaz 2017-10-23 08:28:33 UTC 
Created attachment 362081 [details] [review]
rtpsession: support for receiving GstRTPRetransmissionListRequest
Comment 8 Miguel París Díaz 2017-10-23 08:29:02 UTC 
Created attachment 362082 [details] [review]
rtprtxqueue: add stats about retransmissions
Comment 9 Håvard Graff (hgr) 2017-10-26 08:08:44 UTC 
Could you provide tests for each of these patches? In addition to being "the right thing to do"(tm), it also makes it so much easier to review the intended functionality. :)
Comment 10 GStreamer system administrator 2018-11-03 15:23:10 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/411.