After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789277 - window: rename get_flatpack_id into get_sandboxed_app_id
window: rename get_flatpack_id into get_sandboxed_app_id
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-21 02:47 UTC by Marco Trevisan (Treviño)
Modified: 2017-10-21 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: rename get_flatpack_id into get_sandboxed_app_id (1.91 KB, patch)
2017-10-21 02:47 UTC, Marco Trevisan (Treviño) 		committed Details | Review
window-tracker: use generic meta_window_get_sandboxed_app_id (1.92 KB, patch)
2017-10-21 02:50 UTC, Marco Trevisan (Treviño) 		committed Details | Review
window: rename get_flatpack_id into get_sandboxed_app_id (1.96 KB, patch)
2017-10-21 18:39 UTC, Marco Trevisan (Treviño) 		committed Details | Review
window-tracker: use generic meta_window_get_sandboxed_app_id (1.92 KB, patch)
2017-10-21 18:40 UTC, Marco Trevisan (Treviño) 		committed Details | Review

Description Marco Trevisan (Treviño) 2017-10-21 02:47:45 UTC 
We can now break the API and use more generic name for this
Comment 1 Marco Trevisan (Treviño) 2017-10-21 02:47:48 UTC 
Created attachment 361995 [details] [review]
window: rename get_flatpack_id into get_sandboxed_app_id

This function can be more generic now.
Comment 2 Marco Trevisan (Treviño) 2017-10-21 02:50:12 UTC 
Created attachment 361996 [details] [review]
window-tracker: use generic meta_window_get_sandboxed_app_id

gnome-shell patch too
Comment 3 Florian Müllner 2017-10-21 08:39:54 UTC 
Review of attachment 361995 [details] [review]:

OK

::: src/core/window.c
@@ +7300,3 @@
+ * supported).
+ *
+ * Return value: (transfer none): the Sandboxed application ID or %NULL

sandboxed
Comment 4 Florian Müllner 2017-10-21 08:39:57 UTC 
Review of attachment 361996 [details] [review]:

OK
Comment 5 Marco Trevisan (Treviño) 2017-10-21 18:39:14 UTC 
Comment on attachment 361995 [details] [review]
window: rename get_flatpack_id into get_sandboxed_app_id

The following fix has been pushed:
ab5ac21 window: rename get_flatpack_id into get_sandboxed_app_id
Comment 6 Marco Trevisan (Treviño) 2017-10-21 18:39:18 UTC 
Created attachment 362021 [details] [review]
window: rename get_flatpack_id into get_sandboxed_app_id

This function can be more generic now.
Comment 7 Marco Trevisan (Treviño) 2017-10-21 18:40:19 UTC 
The following fix has been pushed:
f956991 window-tracker: use generic meta_window_get_sandboxed_app_id
Comment 8 Marco Trevisan (Treviño) 2017-10-21 18:40:26 UTC 
Created attachment 362022 [details] [review]
window-tracker: use generic meta_window_get_sandboxed_app_id

This is valid for both Flatpak's and snaps now, we can use a more generic
API then.