After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789251 - Theming issues with gtk2 apps
Theming issues with gtk2 apps
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2017-10-20 14:46 UTC by Antonio Ospite
Modified: 2017-10-20 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Menus in gtk2 apps have styling issues (29.23 KB, image/png)
2017-10-20 14:46 UTC, Antonio Ospite
Details
A reference image of how mutter behaves, (30.14 KB, image/png)
2017-10-20 14:48 UTC, Antonio Ospite
Details

Description Antonio Ospite 2017-10-20 14:46:14 UTC
Created attachment 361956 [details]
Menus in gtk2 apps have styling issues

With metacity 3.26.0 I experience some menu styling issues with gtk2 apps, see
the attached image.

This is with gtk themes:

$ gsettings get org.gnome.metacity.theme type
'gtk'
Comment 1 Antonio Ospite 2017-10-20 14:48:31 UTC
Created attachment 361957 [details]
A reference image of  how mutter behaves,

The menus of gtk2 apps look fine with mutter.
Comment 2 Antonio Ospite 2017-10-20 14:53:16 UTC
Ah, the title also seems a little off in metacity.

BTW I also noticed that all windows get styled as they were CSD windows, but I have no idea if the menu theming bug is related to this new behavior.

the following theme snippet used to work the same in metacity and mutter, producing different borders between CSD and SSD windows, but now it does not work as it used to in metacity:

/* Yellow  border */
decoration {
  box-shadow: 0 3px 9px 1px rgba(0, 0, 0, 0.8), 0 0 0 1px rgba(255, 255, 0, 0.8);
}

decoration:backdrop {
  box-shadow: 0 3px 9px 1px rgba(0, 0, 0, 0.3), 0 0 0 1px rgba(255, 255, 0, 0.3);
}

/* Magenta border */
.ssd decoration {
  box-shadow: 0 0 0 1px rgba(255, 0, 255, 0.8);
}
.ssd decoration:backdrop {
  box-shadow: 0 0 0 1px rgba(255, 0, 255, 0.3);
}
Comment 3 Alberts Muktupāvels 2017-10-20 15:01:47 UTC
The problem here is that gtk+ 2 does not add shadow and it should be added by metacity. I will try to fix that.

Different borders I don't consider as bug, it is intended behaviour. Why would you want different borders?

.ssd was added because mutter has it own shadows and without it you would get csd shadow + mutter shadow. To avoid that .ssd was added to allow themes to remove shadow so you only get shadow from mutter.
Comment 4 Antonio Ospite 2017-10-20 15:47:03 UTC
(In reply to Alberts Muktupāvels from comment #3)
[...]
> Different borders I don't consider as bug, it is intended behaviour. Why
> would you want different borders?
> 
> .ssd was added because mutter has it own shadows and without it you would
> get csd shadow + mutter shadow. To avoid that .ssd was added to allow themes
> to remove shadow so you only get shadow from mutter.

Not that I actually want to have different borders, I was just surprised that the behavior changed, that's all.

Now I know that it's deliberate and that there should be no side effects of the new behavior.

Thanks again,
   Antonio
Comment 5 Alberts Muktupāvels 2017-10-20 16:05:21 UTC
Should be fixed. Now also GTK+ 2 app menus should have menus.