GNOME Bugzilla – Bug 789151
add support for iOS 11
Last modified: 2018-02-15 16:22:54 UTC
Created attachment 361807 [details] [review] proposed patch .
additionally on iOS 11 crt_externs.h header was removed from simulator so the trick here: https://cgit.freedesktop.org/gstreamer/cerbero/tree/config/ios.config#n121 does not work anymore a solutions seems to link from macosx such this sudo ln -s /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/crt_externs.h . it should be linked in both simulator and iphoneos sdk see also here: https://bugs.webkit.org/show_bug.cgi?id=173937
orctest.c:1165:9: error: 'system' is unavailable: not available on iOS ret = system (cmd); I disabled test, no time to provide a proper patch now, sorry, probably we should add a disable-test configure options and enable it when cross compiling for iOS
gnutls compilations fails In file included from libopts.c:35: ./pgusage.c:168:21: error: 'system' is unavailable: not available on iOS ignore_val( system( fil_name)); solved removing the system call
Comment on attachment 361807 [details] [review] proposed patch Please update the patch so that compilation actually works, thanks :)
thanks for the review, the build finished successfully some minutes ago actually I fixed manually the crt_externs.h header not sure how to properly handle the orc compilation failure, I removed the test but probably a configure options should be added or the test should be automatically disabled when ios cross compilation is detected, what do you think about it? regarding the gnutls issue I simply removed the system call, I think is not needed in general but I'm unsure if a such patch could be accepted, what do you think about it? I'm on deadline now, it could take a while before I have some free time to properly fix iOS 11 build
Sounds both acceptable
Created attachment 362093 [details] [review] proposed fix update patch that handle the header links correctly
Created attachment 362104 [details] [review] orc: redefine system on iOS11 on iOS 11 system is not defined, this patch fixs the issue in orc itself, if you want I can provide a cerbero patch too
Created attachment 362105 [details] [review] fix gnutls build for iOS11
Here are the cerbero bits: commit 423e00327946b5204d7f802991906022a67a9028 Author: Nicola Murino <nicola.murino@gmail.com> Date: Mon Oct 23 16:46:04 2017 +0200 gnutls: remove system usage system is not defined in iOS11 https://bugzilla.gnome.org/show_bug.cgi?id=789151 commit 0fbbd565ad9052a14054a501f702749501932aab Author: Nicola Murino <nicola.murino@gmail.com> Date: Mon Oct 23 13:12:16 2017 +0200 cerbero: add support for iOS 11.0 https://bugzilla.gnome.org/show_bug.cgi?id=789151
Comment on attachment 362104 [details] [review] orc: redefine system on iOS11 This is fixed by http://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=dab94600227e7ea9501da0296b9ba28087ebfe59 http://cgit.freedesktop.org/gstreamer/orc/commit/?id=56ec92b41dc303870b873f5a90965780e661db19
Should also go into 1.12.4