After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789134 - gtk3-icon-browser: the copy button is not centred on the dialog
gtk3-icon-browser: the copy button is not centred on the dialog
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-10-18 09:09 UTC by Julian Sparber
Modified: 2017-10-31 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Shows the dialog and the not centred copy button (145.96 KB, image/png)
2017-10-18 09:09 UTC, Julian Sparber
  Details
copy to clipboard is now centerd (2.08 KB, patch)
2017-10-18 11:06 UTC, Julian Sparber
none Details | Review
[PATCH] icon-browser: Centre Copy button in dialog again (2.06 KB, patch)
2017-10-19 14:59 UTC, Julian Sparber
committed Details | Review

Description Julian Sparber 2017-10-18 09:09:53 UTC
Created attachment 361788 [details]
Shows the dialog and the not centred copy button

When exporting an symbolic icon the "copy to clipboard" Button is not centred.
Comment 1 Daniel Boles 2017-10-18 10:54:21 UTC
presumably the width of its row should have been increased when the symbolic icon was added recently

https://git.gnome.org/browse/gtk+/tree/demos/icon-browser/window.ui#n316
Comment 2 Julian Sparber 2017-10-18 10:57:44 UTC
Yes I fixed it already, but head not yet time to upload the patch.
Had trouble installing git-bz.

The problem is I wrote the patch for the svg export months back and back than there was no button. I don't know why the patch wasn't merged before.
Comment 3 Julian Sparber 2017-10-18 11:06:38 UTC
Created attachment 361798 [details] [review]
copy to clipboard is now centerd

This patch moves the button to the same level as the description where it should be, therefore it is centred in the same way as the description label.
Comment 4 Daniel Boles 2017-10-19 14:29:57 UTC
Review of attachment 361798 [details] [review]:

Please fix the split of subject and commit message. Also, the subject should explain what was done, not what the problem was, and fit in 50 characters.

With some fixups for line width (72 characters) and wording, that would be something like:


icon-browser: Centre Copy button in dialog again

This patch moves the "Copy to Clipboard" button into the same container
as the description label, to centre the button regardless of the number
of icons shown in the grid.

::: demos/icon-browser/window.ui
@@ +343,3 @@
+        <child>
+          <object class="GtkButton">
+            <property name="visible">True</property>

Please remove this when forward-porting to master, as it's redundant there.
Comment 5 Julian Sparber 2017-10-19 14:57:22 UTC
(In reply to Daniel Boles from comment #4)
> ::: demos/icon-browser/window.ui
> @@ +343,3 @@
> +        <child>
> +          <object class="GtkButton">
> +            <property name="visible">True</property>
> 
> Please remove this when forward-porting to master, as it's redundant there.

What do you mean? Also when I create the patch from master I get the same diff.
Comment 6 Julian Sparber 2017-10-19 14:59:01 UTC
Created attachment 361883 [details] [review]
[PATCH] icon-browser: Centre Copy button in dialog again

I changed only the commit description.
Comment 7 Daniel Boles 2017-10-19 14:59:43 UTC
I mean that being visible is the default in GTK+ 4, so that line is redundant.

But I see that window.ui in master still includes the visible property elsewhere, so never mind; just leave it in, I guess.
Comment 8 Julian Sparber 2017-10-19 15:06:24 UTC
Ok I see, I was super confused that I should remove the 3 lines. But good to know  that widgets are normally displayed in gtk4
Comment 9 Daniel Boles 2017-10-31 18:49:14 UTC
Thanks for the patch