GNOME Bugzilla – Bug 789066
Migrate from Intltool to Gettext
Last modified: 2018-05-22 13:25:24 UTC
Recent versions of Gettext are able to translate several formats that are used in GNOME applications, so there is really no need anymore to use intltool or GLib’s dated gettext glue.
Created attachment 361685 [details] [review] Migrate from Intltool to Gettext This patch migrates from Intltool to Gettext both autotools and meson. Just as a side note, although they are not used, this patch also extracts the strings from the `org.gnome.gitg.gschema.xml.in` file. At the moment it uses `intltool` with the `--no-translations` option.
Created attachment 361686 [details] [review] Add comment for translators Although `Icon` key is present in the `Desktop` files spec, it should not be translated. This patch adds a comment for translators to avoid the translation of the string used for `Icon`.
Created attachment 361687 [details] [review] Migrate from Intltool to Gettext A very minor update where it removes the call to `autopoint` from `autogen.sh`, as it is already called by `autoreconf` when using `gettext`.
Review of attachment 361687 [details] [review]: ::: data/org.gnome.gitg.gschema.xml.in.in @@ +24,1 @@ <schema gettext-domain="@GETTEXT_PACKAGE@" id="org.gnome.gitg.preferences.main" path="/org/gnome/gitg/preferences/main/"> Will Meson correctly replace @GETTEXT_PACKAGE@ with the gettext domain? ::: po/Makevars @@ +42,3 @@ +# can write to without being subscribed, or the URL of a web page through +# which the translators can contact you. +MSGID_BUGS_ADDRESS = https://bugzilla.gnome.org/enter_bug.cgi?product=gitg&keywords=I18N+L10N&component=general gitg doesn’t have the “general” component.
Created attachment 361696 [details] [review] Migrate from Intltool to Gettext (In reply to Piotr Drąg from comment #4) > Review of attachment 361687 [details] [review] [review]: > > ::: data/org.gnome.gitg.gschema.xml.in.in > @@ +24,1 @@ > <schema gettext-domain="@GETTEXT_PACKAGE@" > id="org.gnome.gitg.preferences.main" > path="/org/gnome/gitg/preferences/main/"> > > Will Meson correctly replace @GETTEXT_PACKAGE@ with the gettext domain? As far as I tried, it does. meson uses the `configure_file` function to replace the `GETTEXT_PACKAGE` token. > ::: po/Makevars > @@ +42,3 @@ > +# can write to without being subscribed, or the URL of a web page through > +# which the translators can contact you. > +MSGID_BUGS_ADDRESS = > https://bugzilla.gnome.org/enter_bug. > cgi?product=gitg&keywords=I18N+L10N&component=general > > gitg doesn’t have the “general” component. I overlooked it. I changed it to `gitg` now.
Great, thanks!
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gitg/issues/100.