After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789064 - meson test: Enable libs tests
meson test: Enable libs tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-16 15:53 UTC by Mathieu Duponchelle
Modified: 2017-12-08 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson test: Enable libs tests (4.48 KB, patch)
2017-10-16 15:53 UTC, Mathieu Duponchelle 		none Details | Review
meson test: Enable libs tests (4.43 KB, patch)
2017-12-04 22:08 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-10-16 15:53:35 UTC 
The libs_gstglheaders test fails on my system, but it also fails with
an autotools build.
Comment 1 Mathieu Duponchelle 2017-10-16 15:53:41 UTC 
Created attachment 361684 [details] [review]
meson test: Enable libs tests
Comment 2 Tim-Philipp Müller 2017-12-04 11:37:24 UTC 
Looks ok. libs/aggregator needs to be removed now.


I think in general that the downloads should be hidden behind a network test switch and that it should be disabled by default, but that's more of a general comment and not relevant to your patch as it applies to the autotools build too.
Comment 3 Tim-Philipp Müller 2017-12-04 11:44:27 UTC 
> I think in general that the downloads should be hidden behind a network test
> switch and that it should be disabled by default

And the patch does that already anyway :)
Comment 4 Mathieu Duponchelle 2017-12-04 22:08:50 UTC 
Created attachment 364953 [details] [review]
meson test: Enable libs tests
Comment 5 Tim-Philipp Müller 2017-12-08 00:52:00 UTC 
Is anything else needed to get this in?
Comment 6 Mathieu Duponchelle 2017-12-08 17:57:03 UTC 
Nothing :)

Attachment 364953 [details] pushed as 58c374c - meson test: Enable libs tests