After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 789045 - Rename gsettings-desktop-schemas VAPI file
Rename gsettings-desktop-schemas VAPI file
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2017-10-16 08:46 UTC by Iñigo Martínez
Modified: 2017-10-16 10:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename gsettings-desktop-schemas VAPI file (2.29 KB, patch)
2017-10-16 08:54 UTC, Iñigo Martínez 		committed Details | Review

Description Iñigo Martínez 2017-10-16 08:46:34 UTC 
Although `gsettings-desktop-schemas` GIR file name is `GDesktopEnums-3.0.gir`, the pkg-config `.pc` is called `gsettings-desktop-schemas.pc`. Following Vala recommendations, the VAPI file should have the same file name as the `.pc` file.
Comment 1 Iñigo Martínez 2017-10-16 08:54:00 UTC 
Created attachment 361652 [details] [review]
Rename gsettings-desktop-schemas VAPI file

This patch changes the gsettings-desktop-schemas VAPI filename from gdesktop-enums-3.0.vapi to gsettings-desktop-schemas.vapi file following Vala recommendations.
Comment 2 Ignacio Casal Quinteiro (nacho) 2017-10-16 09:18:36 UTC 
Review of attachment 361652 [details] [review]:

Go ahead.
Comment 3 Iñigo Martínez 2017-10-16 10:23:15 UTC 
Comment on attachment 361652 [details] [review]
Rename gsettings-desktop-schemas VAPI file

Pushed as d5a822dd - Rename gsettings-desktop-schemas VAPI file