After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788861 - WARNING **: Series with no valid style in legend? Please file a bug report
WARNING **: Series with no valid style in legend? Please file a bug report
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2017-10-12 07:10 UTC by Andreas J. Guelzow
Modified: 2017-10-23 09:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sample file (6.91 KB, application/vnd.oasis.opendocument.spreadsheet)
2017-10-12 07:10 UTC, Andreas J. Guelzow 		  Details
Patch (900 bytes, patch)
2017-10-12 09:59 UTC, Jean Bréfort 		rejected Details | Review

Description Andreas J. Guelzow 2017-10-12 07:10:27 UTC 
Created attachment 361402 [details]
sample file

Opening the attached sample file creates two XLSurfacePlots and many 
WARNING **: Series with no valid style in legend? Please file a bug report
warnings.
Comment 1 Jean Bréfort 2017-10-12 07:43:33 UTC 
I don't see any warning and only one graph with a GogSurface in the sample. Anyway, XLSurfacePlot clearly needs a foreach_elem override.
Comment 2 Andreas J. Guelzow 2017-10-12 09:08:56 UTC 
The warnings should be shown in the terminal window.
Comment 3 Jean Bréfort 2017-10-12 09:23:21 UTC 
The only message I see is:
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
Comment 4 Jean Bréfort 2017-10-12 09:29:45 UTC 
Wait, I need to update gnumeric
Comment 5 Jean Bréfort 2017-10-12 09:59:13 UTC 
Created attachment 361408 [details] [review]
Patch

We might want to be able to import a style. I suppose that we can attach the style to the plot instead of the series. This is a bit weird, but these plots are weird anyway.
Comment 6 Morten Welinder 2017-10-23 01:28:14 UTC 
Any reason not to commit this patch?


with or without the patch I get...
Sheet1!E15
   Duplicate default chart/graphics style encountered.
Comment 7 Andreas J. Guelzow 2017-10-23 02:00:39 UTC 
I see no reason not to commit this. The "Duplicate default chart/graphics style encountered." is an ODF issue.
Comment 8 Jean Bréfort 2017-10-23 06:12:54 UTC 
I'm not sure about the patch because there is nothing left in the legend.
Comment 9 Jean Bréfort 2017-10-23 09:21:55 UTC 
Review of attachment 361408 [details] [review]:

Not optimal, we need to fix with coutour plots as well.
Comment 10 Jean Bréfort 2017-10-23 09:22:38 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.