After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788854 - build: Fix build with multiarch
build: Fix build with multiarch
Status: RESOLVED OBSOLETE
Product: gnome-builder
Classification: Other
Component: libide
3.26.x
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-11 21:54 UTC by Jeremy Bicha
Modified: 2018-01-11 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix build with multiarch (865 bytes, patch)
2017-10-11 21:54 UTC, Jeremy Bicha 		needs-work Details | Review

Description Jeremy Bicha 2017-10-11 21:54:27 UTC 
On Debian-based distros, gnome-builder 3.26.0 installs the Ide.py file to
/usr/lib/x86_64-linux-gnu/python3/dist-packages/gi/overrides/Ide.py

This causes the Jedi plugin to fail because that path isn't part of PYTHONPATH.

The correct location is
/usr/lib/python3/dist-packages/gi/overrides/Ide.py

mbiebl proposed the following patch with the comment
"that code is obviously false for multi-arch, not sure why that check is needed at all"

This bug is a regression introduced with the port to meson (didn't affect Ubuntu 17.04's gnome-builder 3.24 which didn't build with meson)
Comment 1 Jeremy Bicha 2017-10-11 21:54:29 UTC 
Created attachment 361383 [details] [review]
build: Fix build with multiarch

The Python gi override should be installed to a non-multiarch directory
on Debian-based distros.
Comment 2 Patrick Griffis (tingping) 2017-10-11 21:57:00 UTC 
Review of attachment 361383 [details] [review]:

::: src/libide/meson.build
@@ -178,3 @@
 
-if overridedir.startswith(libdir): # Should always be True..
-  overridedir = overridedir[len(libdir) + 1:]

We strip the libdir on purpose so we never install outside of our prefix.

So either we agree that this doesn't matter in which case this can be cleaned up a bit (Remove the join_path() call below) or that we do want to keep that behavior and just need to better handle multi-arch libdirs.
Comment 3 GNOME Infrastructure Team 2018-01-11 10:42:26 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-builder/issues/294.