After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788847 - directsoundsink: minor cleanups
directsoundsink: minor cleanups
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.12.3
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-11 19:34 UTC by Philippe Renon
Modified: 2017-10-12 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
directsoundsink: remove duplicate volume initialization (908 bytes, patch)
2017-10-11 19:35 UTC, Philippe Renon 		committed Details | Review
directsoundsink: simplify how DirecSoundBuffer is cleared (975 bytes, patch)
2017-10-11 19:35 UTC, Philippe Renon 		none Details | Review
directsoundsink: don't call set_volume with private scaled volume (975 bytes, patch)
2017-10-11 19:36 UTC, Philippe Renon 		committed Details | Review
directsoundsink: fix comment (893 bytes, patch)
2017-10-11 19:36 UTC, Philippe Renon 		committed Details | Review
directsoundsink: simplify how DirecSoundBuffer is cleared (1017 bytes, patch)
2017-10-11 19:37 UTC, Philippe Renon 		committed Details | Review

Description Philippe Renon 2017-10-11 19:34:22 UTC 
Some small cleanups.
Comment 1 Philippe Renon 2017-10-11 19:35:10 UTC 
Created attachment 361357 [details] [review]
directsoundsink: remove duplicate volume initialization
Comment 2 Philippe Renon 2017-10-11 19:35:38 UTC 
Created attachment 361358 [details] [review]
directsoundsink: simplify how DirecSoundBuffer is cleared
Comment 3 Philippe Renon 2017-10-11 19:36:26 UTC 
Created attachment 361359 [details] [review]
directsoundsink: don't call set_volume with private scaled volume
Comment 4 Philippe Renon 2017-10-11 19:36:54 UTC 
Created attachment 361361 [details] [review]
directsoundsink: fix comment
Comment 5 Philippe Renon 2017-10-11 19:37:30 UTC 
Created attachment 361362 [details] [review]
directsoundsink: simplify how DirecSoundBuffer is cleared
Comment 6 Sebastian Dröge (slomo) 2017-10-12 07:33:10 UTC 
Please also check if the same/similar changes are needed for directsoundsrc

Attachment 361357 [details] pushed as d519d14 - directsoundsink: remove duplicate volume initialization
Attachment 361359 [details] pushed as 7399314 - directsoundsink: don't call set_volume with private scaled volume
Attachment 361361 [details] pushed as 2456130 - directsoundsink: fix comment
Attachment 361362 [details] pushed as 09af01a - directsoundsink: simplify how DirecSoundBuffer is cleared
Comment 7 Philippe Renon 2017-10-12 07:45:24 UTC 
same/similar changes are not needed by directsoundsrc.