After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788814 - gparted-0.30.0/include/HBoxOperations.h:37]: performance problem
gparted-0.30.0/include/HBoxOperations.h:37]: performance problem
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
0.30.0
Other Linux
: Normal normal
: ---
Assigned To: Mike Fleetwood
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2017-10-11 07:16 UTC by dcb
Modified: 2019-05-29 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Pass constant parameter by reference to load_operations() (v1) (1.62 KB, patch)
2019-03-29 13:54 UTC, Mike Fleetwood 		none Details | Review

Description dcb 2017-10-11 07:16:24 UTC 
gparted-0.30.0/include/HBoxOperations.h:37]: (performance) Function parameter 'operations' should be passed by reference.

Source code is

   void load_operations( const std::vector<Operation *> operations ) ;

More usual code would be

   void load_operations( const std::vector<Operation *> & operations ) ;
Comment 1 Mike Fleetwood 2019-03-29 13:54:05 UTC 
Created attachment 374215 [details] [review]
Pass constant parameter by reference to load_operations() (v1)

Hi Curtis,

Here's a patch for this minor issue.

Thanks,
Mike
Comment 2 Curtis Gedak 2019-03-31 15:36:53 UTC 
Hi Mike,

These code changes look good to me.  If no concerns are raised then I will commit these changes to the git master branch in the next day or so.

Thanks,
Curtis
Comment 3 Curtis Gedak 2019-04-01 15:16:28 UTC 
This patch has been committed to the git master branch for inclusion in the next release of GParted.

The relevant git commit can be viewed at the following link:

Pass constant parameter by reference to load_operations() (#788814)
https://gitlab.gnome.org/GNOME/gparted/commit/97ce96da033358c69285dd76e5ae2ae73ac838a3
Comment 4 Curtis Gedak 2019-05-29 17:06:36 UTC 
This enhancement was included in the GParted 1.0.0 release on May 29, 2019.