GNOME Bugzilla – Bug 788813
gparted-0.30.0/include/Partition.h:137]: performance problem
Last modified: 2019-05-29 17:06:19 UTC
gparted-0.30.0/include/Partition.h:137]: (performance) Function parameter 'msgs' should be passed by reference. Source code is void append_messages( const std::vector<Glib::ustring> msgs ) More usual would be something like void append_messages( const std::vector<Glib::ustring> & msgs )
Created attachment 374214 [details] [review] Pass message parameters by reference to 2 Partition methods (v1) Hi Curtis, Here's patchset v1 for this. As noted in the commit message this change probably makes no performance difference because functions defined in the class are inlined anyway. As this is a pre-GitLab bug, I'm using the pre-GitLab workflow. Thanks, Mike
Hi Mike, These code changes look good to me. I tested on Kubuntu 16.04 and Fedora 29 and no regressions were found. If no concerns are raised then I will commit these changes to the git master branch in the next day or so. Regards, Curtis
These code change have been committed to the git master branch for inclusion in the next release of GParted. The relevant git commits can be viewed at the following links: Pass message parameters by reference to 2 Partition methods (#788813) https://gitlab.gnome.org/GNOME/gparted/commit/454ac64d1905ade9576cd09bb9ef5555d795c619 Go back to symbolic label widget alignment constants https://gitlab.gnome.org/GNOME/gparted/commit/45fd146fd0f7616518caaf77918c1735ad5af5ad
This enhancement was included in the GParted 1.0.0 release on May 29, 2019.