GNOME Bugzilla – Bug 788779
Add the ability to override tarball names
Last modified: 2017-10-10 16:18:15 UTC
New WebKit dependencies come from GitHub in the form of tarballs, and GitHub automatically generates release tarballs with spectacularly unhelpful names.
Created attachment 361250 [details] [review] Add the ability to override tarball names Modules hosted on GitHub have autogenerated tarball names coming from the release tag. This means a lot of them have unhelpful names like 'v1.0.1.tar.gz', or '296.zip'. If two different modules have the same tag, we end up with a collision when trying to check that the tarball downloaded have the same checksum. We can add a simple XML attribute that allows us to rename the tarball if that's the case; we can also throw in variables support for the name of the module and the version, which will hopefully help us to avoid collisions.
Created attachment 361252 [details] [review] Add the ability to override tarball names Modules hosted on GitHub have autogenerated tarball names coming from the release tag. This means a lot of them have unhelpful names like 'v1.0.1.tar.gz', or '296.zip'. If two different modules have the same tag, we end up with a collision when trying to check that the tarball downloaded have the same checksum. We can add a simple XML attribute that allows us to rename the tarball if that's the case; we can also throw in variables support for the name of the module and the version, which will hopefully help us to avoid collisions.
Comment on attachment 361252 [details] [review] Add the ability to override tarball names r=me if Gabriel has tested it
Review of attachment 361252 [details] [review]: OK, tested. It works perfectly. Thanks for working on this, ebassi!
Attachment 361252 [details] pushed as ef5f40c - Add the ability to override tarball names