Bug 788776 – Setting network proxy crashes with SIGSEGV

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 788776 - Setting network proxy crashes with SIGSEGV


Summary:	Setting network proxy crashes with SIGSEGV


Status:	RESOLVED FIXED

Product:	gnome-control-center
Classification:	Core
Component:	Network
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Control-Center Maintainers
QA Contact:	Control-Center Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-10-10 13:26 UTC by Xiang Fan
Modified:	2017-11-01 16:40 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
0001-network-proxy-destroy-dialog-with-the-class.patch (948 bytes, patch) 2017-10-21 03:35 UTC, Xiang Fan	committed	Details \| Review

Description Xiang Fan 2017-10-10 13:26:40 UTC

Reproducible in 3.26:
1. make sure proxy is off, and reopen Settings
1. click Network panel
2. click some other panel
3. go back to Network panel
4. try to change proxy to "manual"
5. watch Settings crash

+ Trace 238043

#0 g_settings_get_enum
#1 check_wpad_warning
at net-proxy.c line 87
#2 settings_changed_cb
at net-proxy.c line 127
#3 g_closure_invoke
#4 0x00007fffec98a0b0 in
#5 g_signal_emit_valist
#6 g_signal_emit
#7 0x00007fffecccb635 in
#8 ffi_call_unix64
#9 ffi_call
#10 g_cclosure_marshal_generic_va
#11 g_signal_emit_valist
#12 g_signal_emit
#13 0x00007fffeccc86df in
#14 0x00007fffeccc7330 in
#15 g_main_context_invoke_full
#16 0x00007fffeccc74a9 in
#17 0x00007fffa137d9d5 in
#18 0x00007fffa137ec07 in
#19 0x00007fffa137d50e in
#20 0x00007fffecc05786 in
#21 g_settings_set_enum
#22 panel_proxy_mode_radio_changed_cb
at net-proxy.c line 176
#23 g_closure_invoke
#24 0x00007fffec98a0b0 in
#25 g_signal_emit_valist
#26 g_signal_emit
#27 0x00007fffee2b441e in
#28 g_signal_emit_valist
#29 g_signal_emit
#30 0x00007fffee14514e in
#31 0x00007fffee1451a6 in
#32 g_closure_invoke
#33 0x00007fffec98a188 in
#34 g_signal_emit_valist
#35 g_signal_emit
#36 0x00007fffee143501 in
#37 ffi_call_unix64
#38 ffi_call
#39 g_cclosure_marshal_generic_va
#40 g_signal_emit_valist
#41 g_signal_emit
#42 0x00007fffee206bc4 in
#43 g_cclosure_marshal_VOID__BOXEDv
#44 g_signal_emit_valist
#45 g_signal_emit
#46 0x00007fffee203d6f in
#47 0x00007fffee2053eb in
#48 0x00007fffee208167 in
#49 gtk_event_controller_handle_event
#50 0x00007fffee3a2784 in
#51 0x00007fffee251fe8 in
#52 g_signal_emit_valist
#53 g_signal_emit
#54 0x00007fffee3a4ae5 in
#55 0x00007fffee24ed4b in
#56 gtk_main_do_event
#57 0x00007fffedd5a6f6 in
#58 0x00007fffedd8d025 in
#59 g_main_context_dispatch
#60 0x00007fffec6a7f69 in
#61 g_main_context_iteration
#62 g_application_run
#63 main
at main.c line 57

Comment 1 Xiang Fan 2017-10-21 03:35:14 UTC

Created attachment 361999 [details] [review]
0001-network-proxy-destroy-dialog-with-the-class.patch

This patch should fix the crash. Can someone please review it?

Comment 2 Rui Matos 2017-11-01 13:56:20 UTC

Review of attachment 361999 [details] [review]:

looks good, thanks. This is an unfortunate common gotcha with GtkBuilder and toplevel windows, see bug 708286

Comment 3 Xiang Fan 2017-11-01 16:27:23 UTC

(In reply to Rui Matos from comment #2)

Thanks for your review. Can you please push this since I don't have push rights?

Comment 4 Rui Matos 2017-11-01 16:40:26 UTC

Sure, thanks for the patch