After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788711 - omx: also reset nTimeStamp when re-using buffers
omx: also reset nTimeStamp when re-using buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal minor
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-09 12:48 UTC by Guillaume Desmottes
Modified: 2017-10-18 06:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omx: factor out gst_omx_buffer_reset() (2.40 KB, patch)
2017-10-09 12:48 UTC, Guillaume Desmottes 		committed Details | Review
omx: also reset nTimeStamp when re-using buffers (833 bytes, patch)
2017-10-09 12:48 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2017-10-09 12:48:10 UTC 
.
Comment 1 Guillaume Desmottes 2017-10-09 12:48:44 UTC 
Created attachment 361179 [details] [review]
omx: factor out gst_omx_buffer_reset()
Comment 2 Guillaume Desmottes 2017-10-09 12:48:49 UTC 
Created attachment 361180 [details] [review]
omx: also reset nTimeStamp when re-using buffers

Some OMX implementations may check if the timestamp of the output buffers
they receive is actually not set.
Comment 3 Nicolas Dufresne (ndufresne) 2017-10-11 17:50:42 UTC 
Review of attachment 361179 [details] [review]:

Good.
Comment 4 Nicolas Dufresne (ndufresne) 2017-10-11 17:51:05 UTC 
Review of attachment 361180 [details] [review]:

Looks safe.
Comment 5 Nicolas Dufresne (ndufresne) 2017-10-11 18:00:22 UTC 
Attachment 361179 [details] pushed as 5146995 - omx: factor out gst_omx_buffer_reset()
Attachment 361180 [details] pushed as b317314 - omx: also reset nTimeStamp when re-using buffers
Comment 6 ast 2017-10-18 04:10:49 UTC 
gcc (Raspbian 6.3.0-18+rpi1) 6.3.0 20170516
Raspberry Pi3

I failed to build today.

gstomx.c: In function ‘gst_omx_buffer_reset’:
gstomx.c:234:28: error: incompatible types when assigning to type ‘OMX_TICKS {aka struct OMX_TICKS}’ from type ‘int’
   buf->omx_buf->nTimeStamp = 0;
Comment 7 Guillaume Desmottes 2017-10-18 06:59:01 UTC 
This is fixed by bug #789052 but the patch hasn't been merged yet.