After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788677 - Magnatune: ValueError: not enough values to unpack (expected 2, got 0)
Magnatune: ValueError: not enough values to unpack (expected 2, got 0)
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-08 16:41 UTC by gkrithi8
Modified: 2017-11-16 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not update progress if all downloads have finished (885 bytes, patch)
2017-10-08 16:43 UTC, gkrithi8 		none Details | Review

Description gkrithi8 2017-10-08 16:41:35 UTC 
Get the following trace during Magnatune album downloading completion.

(rhythmbox:13402): libsoup-CRITICAL **: soup_server_run_async: assertion 'priv->legacy_iface != NULL' failed
Traceback (most recent call last):

+ Trace 238030

  • File "/usr/lib/x86_64-linux-gnu/rhythmbox/plugins/magnatune/MagnatuneSource.py", line 440 in download_finished 
    update_progress(self)
  • File "/usr/lib/x86_64-linux-gnu/rhythmbox/plugins/magnatune/MagnatuneSource.py", line 429 in update_progress 
    complete, total = map(sum, zip(*self.__downloads.values()))
ValueError: not enough values to unpack (expected 2, got 0) 






Comment 1


gkrithi8





          2017-10-08 16:43:17 UTC
        



Created attachment 361139 [details] [review]
Do not update progress if all downloads have finished






Comment 2


Jonathan Matthew





          2017-11-11 11:21:03 UTC
        



I fixed this and a few more problems in commit e0e3f4822.






Comment 3


gkrithi8





          2017-11-16 07:31:33 UTC
        



(In reply to Jonathan Matthew from comment #2)
> I fixed this and a few more problems in commit e0e3f4822.

task_cancellable probably needs to be enabled.

self.__download_progress.props.task_cancellable = True