GNOME Bugzilla – Bug 788672
Optionalise X11 support
Last modified: 2017-11-29 17:18:00 UTC
Created attachment 361135 [details] [review] this patch should allow users that want to, to explicitly disable X11 support Currently X11 support is automagic and can't be turned off. I've attached a patch which optionalises X11 support via the enable_x11 flag
Review of attachment 361135 [details] [review]: > build: optionalise X11 support Upper case after the ": " ::: meson_options.txt @@ +15,3 @@ type: 'boolean', value: false) +option('enable_X11', The option should simply be named "x11". @@ +18,3 @@ + description: 'Enable X11 support (requires libX11)', + type: 'boolean', + value: false) It should probably default to true, as it did before.
> The option should simply be named "x11". Hm, but all the other options also start with either "enable" or "with" so enable_x11 seems more fitting to me - but if you say so, I'll change it. Thanks for looking over it
Created attachment 364578 [details] [review] 0001-build-Optionalise-X11-support.patch
Created attachment 364633 [details] [review] build: Make X11 support optional Don't make X11 support dependent on the presence of libX11 development files on the build system. Add an "x11" option to control whether X11 support should be built or not.
Attachment 364633 [details] pushed as 204082e - build: Make X11 support optional I've changed the commit message slightly. You can see the reasoning about not using "with" or "enable" in bug 790995, which has a link to the Meson guidelines for GNOME. Thanks for the patch!