GNOME Bugzilla – Bug 788584
Bookmark improperly reappears in tag view
Last modified: 2017-11-04 19:27:33 UTC
Open bookmarks popover Switch to tags view Click on the edit button for a bookmark Remove the tag from the bookmark. Notice the bookmark (correctly) is removed from the popover. Add *another* tag to the bookmark. Expected behavior: the popover contents do not change, since it's an unrelated tag Actual behavior: the bookmark appears in the tags popover again (incorrect)
Created attachment 362896 [details] [review] bookmarks-popover: fix to prevent unrelated bookmarks from being added to the tag view popover The patch prevents unrelated bookmarks from appearing in the popover. The patch also prevents tags from being duplicated in tags_list_box. Prior to the patch, newly created tags would appear twice in tags_list_box of the browser instance in which the tag was created. Note that the tag would not be duplicated in new instances of the browser.
Review of attachment 362896 [details] [review]: Forgot about this. I'll review it soon. Thanks! I guess you didn't mean to accept your own patch.
Ok. Thanks. Yeah, I noticed that I unintentionally accepted my own patch but could not find a way to edit the status field.
Review of attachment 362896 [details] [review]: ::: src/bookmarks/ephy-bookmarks-popover.c @@ +99,3 @@ g_assert (EPHY_IS_BOOKMARK (bookmark)); g_assert (EPHY_IS_BOOKMARKS_POPOVER (self)); + It looks like you added some trailing whitespace on this line. (Yay, I found a problem this time!)
Review of attachment 362896 [details] [review]: Also, the first line of the commit message is too long, should be 72 characters max. I could fix these for you myself, but perhaps you'd like to reword the commit message yourself, since your name will be on it.
Created attachment 362986 [details] [review] bookmarks-popover: Do not add bookmarks to unrelated tag view popovers This new patch removes the trailing whitespace and shortens the first line of the commit message.