After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788582 - Wrong line endings and broken tags in eog’s help
Wrong line endings and broken tags in eog’s help
Status: RESOLVED FIXED
Product: l10n
Classification: Infrastructure
Component: Spanish [es]
git master
Other All
: Normal normal
: ---
Assigned To: gnome-es-list@gnome.org
gnome-es-list@gnome.org
Depends on:
Blocks:
 
 
Reported: 2017-10-06 05:58 UTC by Ryan Schmidt
Modified: 2017-10-09 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.76 KB, patch)
2017-10-06 05:58 UTC, Ryan Schmidt 		none Details | Review
Fix line endings (1.27 KB, patch)
2017-10-09 07:32 UTC, Ryan Schmidt 		none Details | Review
Fix gui tags (2.09 KB, patch)
2017-10-09 07:34 UTC, Ryan Schmidt 		none Details | Review

Description Ryan Schmidt 2017-10-06 05:58:31 UTC 
Created attachment 361023 [details] [review]
patch

Hi, there are a couple problem in help/es/es.po.

First, the file uses CRLF line endings -- except for line 4 which contains a lone LF. All of the other po files use only LF line endings.

Second, there are some "gui" tags that appear to be wrong. The attached patch should take care of this.

Afterward, you should convert the file to LF line endings.
Comment 1 Alberto Fanjul 2017-10-06 18:08:58 UTC 
Looks fine to me
Comment 2 Piotr Drąg 2017-10-06 22:23:55 UTC 
I’m afraid Ryan is right.

Ryan, do you mind preparing a proper git-formatted patch, so I can apply your changes and attribute your work?
Comment 3 Ryan Schmidt 2017-10-09 07:32:43 UTC 
Created attachment 361164 [details] [review]
Fix line endings
Comment 4 Ryan Schmidt 2017-10-09 07:34:07 UTC 
Created attachment 361165 [details] [review]
Fix gui tags

My familiarity with git is poor. Are these attachments what you need?
Comment 5 Daniel Mustieles 2017-10-09 08:01:30 UTC 
Last patch seems ok for me. Please commit it and I'll review the translation.

If you need something from my side, ping me ;-)

Thanks!
Comment 6 Piotr Drąg 2017-10-09 14:02:41 UTC 
Yes, that’s exactly what we need. Unfortunately, the first patch wouldn’t apply, so I fixed it slightly differently: https://git.gnome.org/browse/eog/commit/?id=670d7c5b8812fff94c1309667f8563468d81dfd6

The second patch applied cleanly: https://git.gnome.org/browse/eog/commit/?id=382503eff951270eaa833245b7ac4bf551e52d79

Thank you!
Comment 7 Daniel Mustieles 2017-10-09 14:15:14 UTC 
More fixes applied in master branch.

I usually run gtxml (from PyG3t) against PO files to check this kind of typos in translations, but this time I forgot to do it.

Thanks for reporting and fixing it!