After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788576 - Download never starts in ephy. Works fine in Webkit MiniBrowser.
Download never starts in ephy. Works fine in Webkit MiniBrowser.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
http://umap.openstreetmap.fr/en/map/m...
Depends on:
Blocks:
 
 
Reported: 2017-10-05 22:57 UTC by Dan Jacobson
Modified: 2018-01-07 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gsb-utils: Don't crash when handling blob URIs (840 bytes, patch)
2018-01-07 00:24 UTC, Michael Catanzaro
committed Details | Review
Fix download of blob URIs (1.22 KB, patch)
2018-01-07 00:55 UTC, Michael Catanzaro
committed Details | Review

Description Dan Jacobson 2017-10-05 22:57:11 UTC
Visit the URL. Click the share icon on the left, and then 'Download data' on the right.

The Download never starts.

Works fine in Webkit MiniBrowser.
Comment 1 Michael Catanzaro 2017-10-06 05:18:01 UTC
Indeed. Interesting!
Comment 2 Michael Catanzaro 2018-01-06 23:04:51 UTC
As of today, it actually crashes Epiphany.
Comment 3 Michael Catanzaro 2018-01-07 00:23:33 UTC
Well I don't know what was wrong back in 3.26 at the time you reported this bug, but the only problem in master is a small oversight in the Safe Browsing implementation. The download works fine with this fixed.
Comment 4 Michael Catanzaro 2018-01-07 00:24:29 UTC
The following fix has been pushed:
a505a6e gsb-utils: Don't crash when handling blob URIs
Comment 5 Michael Catanzaro 2018-01-07 00:24:32 UTC
Created attachment 366439 [details] [review]
gsb-utils: Don't crash when handling blob URIs
Comment 6 Michael Catanzaro 2018-01-07 00:26:01 UTC
(In reply to Michael Catanzaro from comment #3)
> Well I don't know what was wrong back in 3.26 at the time you reported this
> bug, but the only problem in master is a small oversight in the Safe
> Browsing implementation. The download works fine with this fixed.

Note: it can't be the bug you originally reported, because that code does not exist at all in 3.26.
Comment 7 Michael Catanzaro 2018-01-07 00:30:11 UTC
(In reply to Michael Catanzaro from comment #3)
> Well I don't know what was wrong back in 3.26 at the time you reported this
> bug, but the only problem in master is a small oversight in the Safe
> Browsing implementation. The download works fine with this fixed.

Hm, that's wrong! I had another change locally that accidentally broke something else, which inadvertently fixed this. Hang on....
Comment 8 Michael Catanzaro 2018-01-07 00:55:16 UTC
The following fix has been pushed:
1490f21 Fix download of blob URIs
Comment 9 Michael Catanzaro 2018-01-07 00:55:19 UTC
Created attachment 366441 [details] [review]
Fix download of blob URIs

Epiphany doesn't recognize blob as a web scheme, causing it to try
opening it in an external URI handler in its policy decision callback...
doesn't work.