After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788549 - rtspconnection: needs locking mechanisms?
rtspconnection: needs locking mechanisms?
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-05 08:38 UTC by Jonathan Karlsson
Modified: 2018-11-03 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Test case to show the issue when closing the connection while writing to it (2.86 KB, patch)
2017-10-05 08:38 UTC, Jonathan Karlsson 		none Details | Review

Description Jonathan Karlsson 2017-10-05 08:38:28 UTC 
Created attachment 360949 [details] [review]
Test case to show the issue when closing the connection while writing to it

When looking into 
https://bugzilla.gnome.org/show_bug.cgi?id=785684 and 
https://bugzilla.gnome.org/show_bug.cgi?id=771525, 

we noticed that if the rtspconnection gets closed by one thread while another thread is writing to it, there will be errors. We also noticed that no members of rtspconnection are protected by any locks. Is this intentional?

I have added a test case to show the situation where one thread is sending when the other one is closing.
Is this something we should handle when providing the patch for https://bugzilla.gnome.org/show_bug.cgi?id=785684? Maybe by adding locks, or handling the gst_rtsp_connection_close in some other way in the new write_vectors-method?
Comment 1 GStreamer system administrator 2018-11-03 12:00:35 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/390.