After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788545 - flvmux: Condition always false in function mux_pcm_audio
flvmux: Condition always false in function mux_pcm_audio
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.12.3
Other All
: Normal minor
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-05 05:23 UTC by Ashish Kumar
Modified: 2017-10-05 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix : flvmux: Condition always false in function mux_pcm_audio (765 bytes, patch)
2017-10-05 09:53 UTC, Ashish Kumar 		none Details | Review

Description Ashish Kumar 2017-10-05 05:23:11 UTC 
In 
File : flvmux.c
Function : static void mux_pcm_audio (guint num_buffers, guint repeat)
Line No. 137

Statement
Line No. 137    fail_unless (counter > 2);
is always false 
due to
Line No. 114   counter = 0;


Solution : 
Line No. 114   counter = 0;

should be removed.
Comment 1 Tim-Philipp Müller 2017-10-05 09:34:22 UTC 
Patch please.
Comment 2 Ashish Kumar 2017-10-05 09:53:53 UTC 
Created attachment 360956 [details] [review]
patch to fix : flvmux: Condition always false in function mux_pcm_audio

Please review the patch attached to fix the issue and share the feedback.
Comment 3 Tim-Philipp Müller 2017-10-05 10:09:15 UTC 
I think you will find that this unit test passes just fine and that the counter is actually >2 there, if you add some printf.

There is a

  g_signal_connect (sink, "handoff", G_CALLBACK (handoff_cb), &counter);

outside the loop, but the handoff callback will only be triggered from inside the loop when the pipeline is started.