After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788522 - 3.26: Characters search doesn't work if Recently Used is selected
3.26: Characters search doesn't work if Recently Used is selected
Status: RESOLVED FIXED
Product: gnome-characters
Classification: Other
Component: general
3.26.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Characters maintainer(s)
GNOME Characters maintainer(s)
: 790052 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-10-04 16:30 UTC by Jeremy Bicha
Modified: 2017-11-22 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Fix error when searching on recently used page (763 bytes, patch)
2017-10-05 11:19 UTC, Daiki Ueno 		committed Details | Review

Description Jeremy Bicha 2017-10-04 16:30:44 UTC 
gnome-characters 3.26.1
Ubuntu 17.10 Beta
gjs 1.50.1 (mozjs52)


I tried doing a search from the Recently Used panel of gnome-characters (I think that's the default panel). The search didn't work. Searching from other panels works though.

I got this error when run from a terminal:

(org.gnome.Characters:25368): Gjs-WARNING **: JS ERROR: TypeError: this.visible_child.cancelSearch is not a function
MainView<.cancelSearch@resource:///org/gnome/Characters/js/window.js:421:9
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
MainWindow<._handleSearchChanged@resource:///org/gnome/Characters/js/window.js:177:13
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
main@resource:///org/gnome/Characters/js/main.js:112:13
run@resource:///org/gnome/gjs/modules/package.js:221:12
@/usr/bin/gnome-characters:6:1
Comment 1 Daiki Ueno 2017-10-05 11:19:10 UTC 
Created attachment 360957 [details] [review]
window: Fix error when searching on recently used page
Comment 2 Daiki Ueno 2017-10-05 11:21:40 UTC 
This should fix the issue; I hope someone could help updating the dogtail test to ensure that.
Comment 3 Daiki Ueno 2017-10-23 09:30:21 UTC 
Attachment 360957 [details] pushed as 7fa02c8 - window: Fix error when searching on recently used page
Comment 4 Jeremy Bicha 2017-10-29 17:29:45 UTC 
Thanks. I confirm that commit fixes my issue.
Comment 5 Jeremy Bicha 2017-10-30 13:29:56 UTC 
Do you think you'll have time to do a 3.26.2 release for this?
Comment 6 Jeremy Bicha 2017-10-30 15:14:21 UTC 
Thanks!
Comment 7 Allan Day 2017-11-22 15:15:33 UTC 
*** Bug 790052 has been marked as a duplicate of this bug. ***