After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788469 - Misc Flatpak-related fixes
Misc Flatpak-related fixes
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-10-03 12:46 UTC by Mathieu Bridon
Modified: 2017-10-04 19:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flatpak: Use the modern buildsystem property (1.28 KB, patch)
2017-10-03 12:46 UTC, Mathieu Bridon 		committed Details | Review
flatpak: Allow talking to logind (818 bytes, patch)
2017-10-03 12:47 UTC, Mathieu Bridon 		committed Details | Review
flatpak: Use spaces everywhere, not tabs (783 bytes, patch)
2017-10-03 12:47 UTC, Mathieu Bridon 		committed Details | Review
Fix the appdata screenshot size (1.00 KB, patch)
2017-10-03 12:47 UTC, Mathieu Bridon 		committed Details | Review

Description Mathieu Bridon 2017-10-03 12:46:54 UTC 
.
Comment 1 Mathieu Bridon 2017-10-03 12:46:58 UTC 
Created attachment 360829 [details] [review]
flatpak: Use the modern buildsystem property
Comment 2 Mathieu Bridon 2017-10-03 12:47:02 UTC 
Created attachment 360830 [details] [review]
flatpak: Allow talking to logind
Comment 3 Mathieu Bridon 2017-10-03 12:47:08 UTC 
Created attachment 360831 [details] [review]
flatpak: Use spaces everywhere, not tabs
Comment 4 Mathieu Bridon 2017-10-03 12:47:13 UTC 
Created attachment 360832 [details] [review]
Fix the appdata screenshot size
Comment 5 Mathieu Bridon 2017-10-03 12:48:26 UTC 
Review of attachment 360832 [details] [review]:

One note about this patch: I'm not sure whether the best is to fix the appdata so it lists the right size, or to redo the screenshots so they have a more standard size.

I guess that depends on how GNOME Software handles screenshots. :-/
Comment 6 Georges Basile Stavracas Neto 2017-10-04 19:07:55 UTC 
Review of attachment 360829 [details] [review]:

++
Comment 7 Georges Basile Stavracas Neto 2017-10-04 19:08:13 UTC 
Review of attachment 360830 [details] [review]:

++
Comment 8 Georges Basile Stavracas Neto 2017-10-04 19:08:27 UTC 
Review of attachment 360831 [details] [review]:

++
Comment 9 Georges Basile Stavracas Neto 2017-10-04 19:08:52 UTC 
Review of attachment 360832 [details] [review]:

I'm fine with it for now.
Comment 10 Georges Basile Stavracas Neto 2017-10-04 19:10:23 UTC 
Attachment 360829 [details] pushed as d07ef35 - flatpak: Use the modern buildsystem property
Attachment 360830 [details] pushed as 66b55bf - flatpak: Allow talking to logind
Attachment 360831 [details] pushed as 19db9ef - flatpak: Use spaces everywhere, not tabs
Attachment 360832 [details] pushed as 18af568 - Fix the appdata screenshot size