GNOME Bugzilla – Bug 788402
osxvideosink build fails on mac OS < 12.0
Last modified: 2018-02-08 16:25:51 UTC
In master, some changes have been made in osxvideosink to get rid of deprecated macro names (events, etc). There is a test to #define the old names: #if MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_12 This does not actually work since on older XCode versions MAC_OS_X_VERSION_10_12 is not defined. Apple's own documentation says to use the version macro *value* in this case. The attached patch fixes this.
Created attachment 360728 [details] [review] Patch to fix build on mac OS < 12.0
For reference: https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/cross_development/Using/using.html#//apple_ref/doc/uid/20002000-1114741-CJADDEIB
Hello, happy new year. Any reason this is still open even though #788404 has been accepted ?
Sorry, pushed now: commit 891425d537850705aeb0b98ea18beb3f4eb12518 (HEAD -> master) Author: Jérôme Laheurte <jerome@jeromelaheurte.net> Date: Sun Oct 1 18:21:26 2017 +0200 osxvideosink: fix build on macOS versions < 12.0 Use value instead of version macro when testing for mac OS version, since the define for the newer version may not be defined when compiling against older versions. https://bugzilla.gnome.org/show_bug.cgi?id=788402
Very cool, thanks.