GNOME Bugzilla – Bug 788309
Various translation related fixes
Last modified: 2017-10-03 19:02:36 UTC
Recent versions of Gettext are able to translate several formats that are used in GNOME applications, so there is really no need anymore to use intltool or GLib’s dated gettext glue.
Created attachment 360631 [details] [review] Migrate from Intltool to Gettext This patch migrates from Intltool to Gettext in autotools and modifies meson to use the same files.
Created attachment 360634 [details] [review] Migrate from Intltool to Gettext This patch migrates from Intltool to Gettext in autotools and modifies meson to use the same files.
Comment on attachment 360634 [details] [review] Migrate from Intltool to Gettext Due to problems in bugzilla, I've uploaded the patch twice.
Review of attachment 360634 [details] [review]: Please, go ahead and commit it.
Created attachment 360640 [details] [review] Fix missing translations Gettext support in autotools does define ENABLE_NLS macro to 1 in the autoconf generated configuration file. Due to the migration to the meson build system, this define is missing. There is no reason to really disable i18n, so this patch removes the condition that binds the text domain. I've tried with both autotools and meson and translations are working now. Some pictures: https://imgur.com/a/FiDUc
Comment on attachment 360631 [details] [review] Migrate from Intltool to Gettext Pushed as f247157 - build: Migrate from Intltool to Gettext
Comment on attachment 360640 [details] [review] Fix missing translations Pushed 4ec58db - build: Fix missing translations
Created attachment 360681 [details] [review] Fix gschema file remove I have been reviewing the gnome-nettool patches and I've noticed a bug that was introduced in autotools, because it removes the `gschema` file, when actually it shouldn't. This patch fixes this problem.
Review of attachment 360681 [details] [review]: Pushed. Thank you!
I believe this is all what we need.