After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788303 - daemon: Remove obsolete module gdm-xerrors
daemon: Remove obsolete module gdm-xerrors
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-28 18:22 UTC by Robert Ancell
Modified: 2017-09-28 19:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
daemon: Remove obsolete module gdm-xerrors (11.57 KB, patch)
2017-09-28 18:22 UTC, Robert Ancell 		accepted-commit_now Details | Review

Description Robert Ancell 2017-09-28 18:22:48 UTC 
This code is not used anywhere in GDM anymore.
Comment 1 Robert Ancell 2017-09-28 18:22:51 UTC 
Created attachment 360626 [details] [review]
daemon: Remove obsolete module gdm-xerrors
Comment 2 Ray Strode [halfline] 2017-09-28 18:28:12 UTC 
Review of attachment 360626 [details] [review]:

sure, except for a nit

::: daemon/gdm-display.c
@@ +37,2 @@
 #include <xcb/xcb.h>
+#include <X11/Xlib.h>

should be a separate commit.
Comment 3 Ray Strode [halfline] 2017-09-28 18:30:30 UTC 
(nevermind, it doesn't matter)
Comment 4 Robert Ancell 2017-09-28 19:15:31 UTC 
Why should it be a separate commit? Removing the gdm-xerrors.h include broke gdm-display.c because that was the X11/Xlib.h include was the only part from gdm-xerrors.h that was being used.