After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788245 - h263enc: fix caps leak in error code path
h263enc: fix caps leak in error code path
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
1.13.x
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-27 14:23 UTC by Ponnam Srinivas
Modified: 2017-09-28 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch file attached (864 bytes, patch)
2017-09-27 14:23 UTC, Ponnam Srinivas 		committed Details | Review

Description Ponnam Srinivas 2017-09-27 14:23:05 UTC 
Created attachment 360538 [details] [review]
patch file attached

Hi,

In gst_omx_h263_enc_get_caps() , in default switch case,  caps unref is missed.
This lead to memory leak.

default:
        g_assert_not_reached ();
        return NULL;


sol:

gst_caps_unref (caps); added.

Please review and share feedback.
Comment 1 Sebastian Dröge (slomo) 2017-09-28 10:25:02 UTC 
commit 855659686252474b52253e57e1db869900caea32 (HEAD -> master)
Author: Ponnam Srinivas <p.srinivas@samsung.com>
Date:   Wed Sep 27 19:47:29 2017 +0530

    h263enc: fix caps leak in error code path
    
    https://bugzilla.gnome.org/show_bug.cgi?id=788245