GNOME Bugzilla – Bug 788217
Support snap packages for sandboxed app IDs
Last modified: 2017-10-21 02:17:50 UTC
In order to get snap applications to be proprely matched in gnome shell we need to fetch the app id from the snap security profile and generate the .desktop basename from that. Attached patch is intented to be for the stable branch, while we should break the API for next release replacing meta_window_get_flatpak_id with meta_window_get_sandboxed_app_id
Created attachment 360499 [details] [review] Window: support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API.
Created attachment 360501 [details] [review] Window: support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API.
Created attachment 360512 [details] [review] Window: support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API.
Created attachment 360534 [details] [review] Window: support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API.
Review of attachment 360534 [details] [review]: Looks reasonable as a stop-gap solution for 3.26 (as we can't introduce/change API), as the assumptions made by gnome-shell (using the getter API that is abused here) are still valid for snap applications. For 3.28 we should adapt the API, and renaming 'meta_window_get_flatpak_id()' to 'meta_window_get_sandbox_app_id()' seems like a reasonable thing to do to me, as a window will never be sandboxed by two frameworks at the same time. commit message subject nit: 'window: Support snap packages for sandboxed app Ids' (notice capitalization).
Fixed in https://git.gnome.org/browse/mutter/commit/?id=6dc499f
Review of attachment 360534 [details] [review]: .