After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788216 - privacy panel: add support for Whoopsie
privacy panel: add support for Whoopsie
Status: RESOLVED WONTFIX
Product: gnome-control-center
Classification: Core
Component: Privacy
git master
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-26 21:25 UTC by James Henstridge
Modified: 2018-01-23 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-panels-privacy-add-Whoopsie-support-to-privacy-panel.patch (8.50 KB, patch)
2017-09-26 21:25 UTC, James Henstridge
rejected Details | Review

Description James Henstridge 2017-09-26 21:25:11 UTC
Created attachment 360498 [details] [review]
0001-panels-privacy-add-Whoopsie-support-to-privacy-panel.patch

This is a patch we're shipping in Ubuntu 17.10, and I thought I'd post it here too in case there is interest in merging something like this upstream.

It hooks up the "Problem Reporting" section of the privacy panel to control Whoopsie (Ubuntu's crash reporting system), to complement the existing support for Fedora's ABRT.

I'd imagine this would require some changes would be required to make this a bit easier to maintain upstream, which I'd be happy to help with.  For example, I could probably get rid of the libwhoopsie-preferences dependency by using a generic GDBusProxy.

From what I can see the main differences between the Whoopsie and ABRT as far as the privacy panel would be concerned are:

1. ABRT has a long running service on the system bus, while the "whoopsie-preferences" service starts on demand and exits after a timeout.  So simply checking that the service is running won't work for Whoopsie.

2. Enabling/disabling creation of crash reports is a global setting for Whoopsie, so we can't tie it to a particular user's GSettings value.  Instead, we use the whoopsie-preferences D-Bus API to toggle it.
Comment 1 Georges Basile Stavracas Neto 2018-01-23 00:55:19 UTC
Review of attachment 360498 [details] [review]:

Hi James, thanks for sending this patch, and sorry for the delay.

Usually, this kind of very downstream specific changes are not well suited for upstream. GNOME's codebase should be as distro-agnostic as possible.

However, I'd gladly review and accept distro-agnostic patches that would make maintaining your downstream patches easier. If you have something on your mind that would help, don't hesitate to send a patch. Bonus points if these changes help other distros with their downstream changes =)

I understand this might not be the answer you were expecting, but I hope we can find a good middle ground between up and downstream here. Your contribution and will to engage with upstream, however, is highly appreciated, and I'm personally wishing to see more patches from you again.

I'll close this bug, since it's related to add Whoopsie. If you have further patches, please open a new ticket.