After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788205 - background: Remove GdkColor deprecation warnings
background: Remove GdkColor deprecation warnings
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
git master
Other Linux
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-26 18:59 UTC by Robert Ancell
Modified: 2018-01-31 20:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
background: Remove GdkColor deprecation warnings (2.24 KB, patch)
2017-09-26 18:59 UTC, Robert Ancell 		reviewed Details | Review
background: Remove GdkColor deprecation warnings (2.47 KB, patch)
2017-11-03 02:18 UTC, Robert Ancell 		none Details | Review
background: Remove GdkColor deprecation warnings (2.78 KB, patch)
2018-01-29 20:16 UTC, Robert Ancell 		accepted-commit_now Details | Review

Description Robert Ancell 2017-09-26 18:59:26 UTC 
Created attachment 360479 [details] [review]
background: Remove GdkColor deprecation warnings

Switch from deprecated GdkColor to GdkRGBA
Comment 1 Rui Matos 2017-11-01 15:44:37 UTC 
Review of attachment 360479 [details] [review]:

::: panels/background/cc-background-item.c
@@ +182,3 @@
+        s.green = scolor.green * 65535;
+        s.blue = scolor.blue * 65535;
+        gnome_bg_set_color (item->bg, item->shading, &p, &s);

I don't see much point in porting the rest of the code while having to keep this for this API
Comment 2 Robert Ancell 2017-11-03 02:13:10 UTC 
I've opened bug 789840 to add new API to libgnome-desktop so we can drop this workaround.
Comment 3 Robert Ancell 2017-11-03 02:18:44 UTC 
Created attachment 362863 [details] [review]
background: Remove GdkColor deprecation warnings

Equivalent patch if the change in bug 789840 is accepted.
Comment 4 Georges Basile Stavracas Neto 2018-01-26 02:42:31 UTC 
Comment on attachment 360479 [details] [review]
background: Remove GdkColor deprecation warnings

Marking the first patch as obsolete. Let's get the patch at bug 789840 merged, then we apply this one.
Comment 5 Georges Basile Stavracas Neto 2018-01-26 02:43:21 UTC 
Review of attachment 362863 [details] [review]:

Blocked by 789840, but it looks good to me.
Comment 6 Robert Ancell 2018-01-29 20:16:46 UTC 
Created attachment 367605 [details] [review]
background: Remove GdkColor deprecation warnings

Rebase on master, bump gnome-desktop version.
Comment 7 Bastien Nocera 2018-01-30 09:18:16 UTC 
Review of attachment 367605 [details] [review]:

Looks good.
Comment 8 Michael Catanzaro 2018-01-31 19:28:28 UTC 
Reopening because this was never pushed.

Please do bump the gnome-desktop version in configure.ac when pushing.
Comment 9 Michael Catanzaro 2018-01-31 19:28:49 UTC 
I mean, in gnome-desktop's configure.ac.
Comment 10 Robert Ancell 2018-01-31 20:11:43 UTC 
Weird, I swear I pushed it...
Comment 11 Michael Catanzaro 2018-01-31 20:43:27 UTC 
(In reply to Michael Catanzaro from comment #9)
> I mean, in gnome-desktop's configure.ac.

I'll do this now