After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788182 - Make the features list separator localizable
Make the features list separator localizable
Status: RESOLVED FIXED
Product: gnome-font-viewer
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-font-viewer-maint
gnome-font-viewer-maint
Depends on:
Blocks:
 
 
Reported: 2017-09-26 11:34 UTC by Khaled Hosny
Modified: 2017-10-30 22:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.00 KB, patch)
2017-09-26 11:34 UTC, Khaled Hosny 		none Details | Review
Patch, v2 (1.12 KB, patch)
2017-09-27 06:29 UTC, Khaled Hosny 		committed Details | Review

Description Khaled Hosny 2017-09-26 11:34:52 UTC 
Created attachment 360429 [details] [review]
Patch

The layout features list in the new details tab hard-codes ", " as list separator, but some languages (e.g. Arabic) need to use a different character.
Comment 1 Cosimo Cecchi 2017-09-26 23:38:08 UTC 
Review of attachment 360429 [details] [review]:

Thanks for the patch; please see my comment below.

::: src/font-view.c
@@ +302,3 @@
                     if (open_type_layout_features[k].tag == features[j]) {
                         if (s->len > 0)
+                            g_string_append (s, _(", "));

Please add a comment for translators about which context this is used for.
Comment 2 Khaled Hosny 2017-09-27 06:29:28 UTC 
Created attachment 360515 [details] [review]
Patch, v2

Add a comment and and a msgctxt.
Comment 3 Cosimo Cecchi 2017-10-04 19:20:49 UTC 
Review of attachment 360515 [details] [review]:

OK, thanks!
Comment 4 Cosimo Cecchi 2017-10-30 22:59:54 UTC 
Pushed to master.