After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788134 - Plugins metadata in GNOME Software is not translated
Plugins metadata in GNOME Software is not translated
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-25 13:29 UTC by Piotr Drąg
Modified: 2019-03-23 20:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of the issue (67.02 KB, image/png)
2017-09-25 13:29 UTC, Piotr Drąg 		  Details
Fix translation of plugins metainfo (16.52 KB, patch)
2017-09-28 17:22 UTC, Michael Catanzaro 		committed Details | Review

Description Piotr Drąg 2017-09-25 13:29:55 UTC 
Created attachment 360356 [details]
Screenshot of the issue

Plugins names and descriptions in gnome-software are not translated.

gedit-plugins-3.22.0-4.fc27
Comment 1 Michael Catanzaro 2017-09-28 17:22:15 UTC 
Created attachment 360618 [details] [review]
Fix translation of plugins metainfo

It's not translated because INTLTOOL_XML_NOMERGE_RULE is used, but the
metainfo files require that the translations be merged into them. So
switch to normal INTLTOOL_XML_RULE.

Now, gedit-plugins was relying on INTLTOOL_XML_NOMERGE_RULE for its
GSettings translation support. This is pointless as intltool has had
GSettings support since 2012. Rely on it. This avoids the problem that
you can't use both the merge rule and the nomerge rule in the same
Makefile.am.

gedit-plugins should really not be using intltool at all anymore. It's
obsolete. Switching is not hard, but I'm not going to fix that today.
Comment 2 Michael Catanzaro 2017-09-28 17:24:15 UTC 
I've also stopped substituting gedit-plugins for @GETTEXT_DOMAIN@ using a configure replacement... that's a lot of extra complexity for not very much benefit. So we can go from .gschema.xml.in.in to simple .gschema.xml.
Comment 3 Piotr Drąg 2017-09-28 17:33:34 UTC 
Comment on attachment 360618 [details] [review]
Fix translation of plugins metainfo

I tested the patch and now AppData files include translations. Pushed as a8cfb02a87c3bd634152b9b944f41d186d582b3b. Thank you so much!