After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788115 - Update pango_default_break function for Line Break
Update pango_default_break function for Line Break
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on: 789625
Blocks:
 
 
Reported: 2017-09-25 05:31 UTC by Peng Wu
Modified: 2017-10-30 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update pango_default_break function for Line Break (43.01 KB, patch)
2017-09-25 05:35 UTC, Peng Wu 		none Details | Review
Update pango_default_break function for Line Break (52.25 KB, patch)
2017-10-12 02:19 UTC, Peng Wu 		none Details | Review
Update pango_default_break function for Line Break (53.19 KB, patch)
2017-10-12 05:26 UTC, Peng Wu 		none Details | Review
Update pango_default_break function for Line Break (36.06 KB, patch)
2017-10-12 06:26 UTC, Peng Wu 		committed Details | Review

Description Peng Wu 2017-09-25 05:31:44 UTC 
Currently I am working on updating pango_default_break function
for line break of Unicode 9.0 .

There are still about 100 failed test cases of Unicode 9.0,
I am investigating the remained test cases.
Comment 1 Peng Wu 2017-09-25 05:35:08 UTC 
Created attachment 360333 [details] [review]
Update pango_default_break function for Line Break

Support Line Break of Unicode 9.0.
Comment 2 Peng Wu 2017-10-12 02:19:05 UTC 
Created attachment 361388 [details] [review]
Update pango_default_break function for Line Break

Support Line Break of Unicode 9.0.
Comment 3 Peng Wu 2017-10-12 05:26:02 UTC 
Created attachment 361398 [details] [review]
Update pango_default_break function for Line Break

Support Line Break of Unicode 9.0.
Comment 4 Peng Wu 2017-10-12 06:26:21 UTC 
Created attachment 361401 [details] [review]
Update pango_default_break function for Line Break

Support Line Break of Unicode 9.0.
Comment 5 Behdad Esfahbod 2017-10-12 15:17:20 UTC 
lgtm
Comment 6 Peng Wu 2017-10-18 07:45:58 UTC 
The above patch passed the line break test of Unicode 10.0.

Could you review and merge it?
Comment 7 Behdad Esfahbod 2017-10-27 06:03:44 UTC 
As I said, looks good to me.  Matthias can review and merge.
Comment 8 Matthias Clasen 2017-10-27 21:38:55 UTC 
Attachment 361401 [details] pushed as c461948 - Update pango_default_break function for Line Break
Comment 9 Christoph Reiter (lazka) 2017-10-29 08:53:24 UTC 
There is a post regarding line breaking changes on /r/archlinux: https://www.reddit.com/r/archlinux/comments/79byox/pango_broke_my_thunar/

Not sure if this bug/patch is the cause or if that's intended behavior but I thought I'd mention it.
Comment 10 Peng Wu 2017-10-30 02:48:14 UTC 
Thanks for the review!

Okay, I will check the above issue.
Comment 11 Jan Alexander Steffens (heftig) 2017-10-30 19:58:53 UTC 
(In reply to Christoph Reiter (lazka) from comment #9)
(In reply to Peng Wu from comment #10)

The bug for that issue is bug 789625. There's already some analysis in the comments.