After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 788066 - End process dialog box title expands to full length of process title
End process dialog box title expands to full length of process title
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
3.22.x
Other Linux
: Normal minor
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2017-09-22 21:11 UTC by SL
Modified: 2018-05-11 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of confirmation dialog box (38.53 KB, image/png)
2017-09-22 21:11 UTC, SL
  Details
0001-dialog-use-short-process-name-instead-of-full.patch (2.62 KB, patch)
2018-03-15 11:57 UTC, Ognjen Galic
committed Details | Review

Description SL 2017-09-22 21:11:37 UTC
Created attachment 360294 [details]
Screenshot of confirmation dialog box

Overview:

When a process title is extremely long, in this case the chrome debugger title, the `end process` confirmation dialog box expands to the full width of the title.

Reproduce:

Open an instance of google chrome (beta), or create a process with a massive window title.

Suggestion:

Wrap and or scroll content greater than a certain size.
Comment 1 Robert Roth 2018-02-02 23:02:50 UTC
Title of the dialog is wrapped in the 3.26, the current stable version (probably changed in gtk). Marking as fixed.

Do you still see this issue?
Comment 2 Ognjen Galic 2018-03-15 11:40:36 UTC
This has not been fixed and I get this bug in 3.28. 
I'll write a patch.

https://i.imgur.com/799qRPV.png
Comment 3 Ognjen Galic 2018-03-15 11:57:21 UTC
Created attachment 369730 [details] [review]
0001-dialog-use-short-process-name-instead-of-full.patch

This is a patch that fixes this issue by displaying only the executable name in the dialog without the command line parameters.
Comment 4 Robert Roth 2018-03-15 12:10:22 UTC
Thanks for your contribution. Indeed, based on your screenshot this wasn't fixed, although I'm absolutely sure I checked with a chrome process. In any case, I'll probably take your patch, and also comment with a todo to remove the changes once we have the fix in gtop. libgtop is the library which provides us with the process name, and I have checked that the process  commandline is not split correctly there. I would like to fix it there, but as for now, I'll push this and have it released with 3.28.1.
Comment 5 Ognjen Galic 2018-03-15 12:24:25 UTC
Sounds good.

Thanks for merging!
Comment 6 Ognjen Galic 2018-05-09 08:39:53 UTC
So what happened to this patch? I don't see it in 3.28.1 released a few days ago.

Not a problem, just curious as the bug is still present on Ubuntu Bionic.
Comment 7 Robert Roth 2018-05-09 14:45:10 UTC
(In reply to Ognjen Galic from comment #6)
> So what happened to this patch? I don't see it in 3.28.1 released a few days
> ago.
It was not in there. I did promise to merge it, but I didn't (not sure how I managed to forget it, and a sorry doesn't really help). Doing it right now, and making a quick 3.28.2 build today.
> 
> Not a problem, just curious as the bug is still present on Ubuntu Bionic.
Sorry again, I hope I'll manage not doing anything like this next time.
Comment 8 SL 2018-05-09 14:54:19 UTC
Thanks for fixing and taking care of it!
Comment 9 Ognjen Galic 2018-05-09 15:59:11 UTC
No problem, I enjoyed it.
Comment 10 Robert Roth 2018-05-11 05:51:53 UTC
3.28.2 was officially released by GNOME and includes the fix, being a minor release I think it should get in the Ubuntu package repositories soon. Thanks for your contribution and for your patience.
Comment 11 Ognjen Galic 2018-05-11 08:40:07 UTC
Thanks for merging.